Bug 109642 - [Internals] setShadowDOMEnabled() shouldn't be used except a few tests
Summary: [Internals] setShadowDOMEnabled() shouldn't be used except a few tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 17:57 PST by Hajime Morrita
Modified: 2013-02-12 23:36 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.64 KB, patch)
2013-02-12 18:49 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (4.67 KB, patch)
2013-02-12 23:16 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2013-02-12 17:57:31 PST
https://code.google.com/p/chromium/issues/detail?id=174033
The misuse of the flag can cause an assertion failure.
Comment 1 Hajime Morrita 2013-02-12 18:49:12 PST
Created attachment 187991 [details]
Patch
Comment 2 Kent Tamura 2013-02-12 23:09:05 PST
Comment on attachment 187991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187991&action=review

Looks ugly hack. But I also have no other ideas.

> Source/WebCore/ChangeLog:8
> +        InternalSettings.setShadowDOMEnabled() shouldn't be alled after

alled -> called?

> Source/WebCore/testing/InternalSettings.cpp:198
> +static bool urlIsWhitelisted(const String& url)

The function name is too generic.  urlIsInWhitelistForSetShadowDOMEnabled?
Comment 3 Hajime Morrita 2013-02-12 23:16:42 PST
Comment on attachment 187991 [details]
Patch

Thanks for taking a look! I'm addressing the point and landing.
Comment 4 Hajime Morrita 2013-02-12 23:16:55 PST
Created attachment 188018 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-02-12 23:36:26 PST
Comment on attachment 188018 [details]
Patch for landing

Clearing flags on attachment: 188018

Committed r142726: <http://trac.webkit.org/changeset/142726>
Comment 6 WebKit Review Bot 2013-02-12 23:36:29 PST
All reviewed patches have been landed.  Closing bug.