Bug 109634 - [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
Summary: [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
Depends on: 109791
  Show dependency treegraph
Reported: 2013-02-12 17:00 PST by James Robinson
Modified: 2013-02-20 18:11 PST (History)
7 users (show)

See Also:

Patch (4.28 KB, patch)
2013-02-12 17:03 PST, James Robinson
no flags Details | Formatted Diff | Diff
Patch (6.48 KB, patch)
2013-02-12 18:23 PST, James Robinson
no flags Details | Formatted Diff | Diff
Patch (6.38 KB, patch)
2013-02-13 16:30 PST, James Robinson
enne: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-02-12 17:00:11 PST
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
Comment 1 James Robinson 2013-02-12 17:03:01 PST
Created attachment 187965 [details]
Comment 2 James Robinson 2013-02-12 18:23:59 PST
Created attachment 187982 [details]
Comment 3 James Robinson 2013-02-13 16:30:53 PST
Created attachment 188218 [details]
Comment 4 WebKit Review Bot 2013-02-13 16:37:08 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Adrienne Walker 2013-02-13 17:16:35 PST
Comment on attachment 188218 [details]

Comment 6 James Robinson 2013-02-13 18:31:59 PST
Committed r142841: <http://trac.webkit.org/changeset/142841>
Comment 7 WebKit Review Bot 2013-02-14 01:01:50 PST
Re-opened since this is blocked by bug 109791
Comment 8 Andrew Wilson 2013-02-14 01:21:35 PST
Seeing some crashes on the chrome canaries (webkit_unit_tests) http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/6453/steps/webkit_unit_tests/logs/stdio:

[==========] Running 176 tests from 36 test cases.
[----------] Global test environment set-up.
[----------] 1 test from GraphicsLayerChromiumTest
[ RUN      ] GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations
third_party/WebKit/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp(66) : (anonymous namespace)::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()
[ CRASHED      ]
Comment 9 James Robinson 2013-02-14 10:58:13 PST
D'oh, changed the caller to the new interface before implementing it on the chromium side.  Will reland with a fix.
Comment 10 James Robinson 2013-02-14 14:12:46 PST
I have a fix, but Adam pointed out we can statically link webkit_support into DRT and use that instead of adding a new Platform path for DRT.  I'll try that and leave the unit test path alone (that one has to go through Platform API since it's inside WebKit.dll)
Comment 11 James Robinson 2013-02-20 18:11:31 PST
Committed r143547: <http://trac.webkit.org/changeset/143547>