[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
Created attachment 187965 [details]
Created attachment 187982 [details]
Created attachment 188218 [details]
Please wait for approval from firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com or firstname.lastname@example.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 188218 [details]
Committed r142841: <http://trac.webkit.org/changeset/142841>
Re-opened since this is blocked by bug 109791
Seeing some crashes on the chrome canaries (webkit_unit_tests) http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/6453/steps/webkit_unit_tests/logs/stdio:
[==========] Running 176 tests from 36 test cases.
[----------] Global test environment set-up.
[----------] 1 test from GraphicsLayerChromiumTest
[ RUN ] GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations
ASSERTION FAILED: m_layerTreeView
third_party/WebKit/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp(66) : (anonymous namespace)::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest()
[ CRASHED ]
D'oh, changed the caller to the new interface before implementing it on the chromium side. Will reland with a fix.
I have a fix, but Adam pointed out we can statically link webkit_support into DRT and use that instead of adding a new Platform path for DRT. I'll try that and leave the unit test path alone (that one has to go through Platform API since it's inside WebKit.dll)
Committed r143547: <http://trac.webkit.org/changeset/143547>