Bug 109629 - [Windows] Revise WebKit Project to Show Generated Export Definition Files
Summary: [Windows] Revise WebKit Project to Show Generated Export Definition Files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 16:37 PST by Brent Fulgham
Modified: 2013-06-13 10:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2013-02-12 16:56 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-06-13 09:24 PDT, Brent Fulgham 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-02-12 16:37:22 PST 
I recently wasted a bit of time trying to track down a linker error, only to later realize that the problem was that the JavaScriptCoreExportGenerator project had emitted an empty JavaScriptCoreExports.def file.

Since these files are now autogenerated, I think it would be nice if they appeared in the relevant project files as "Generated" sources that could be easily inspected from within Visual Studio.

The attached patch adds these two files, so they can be quickly checked to confirm proper generator function.
Comment 1 Brent Fulgham 2013-02-12 16:56:12 PST 
Created attachment 187962 [details]
Patch
Comment 2 Brent Fulgham 2013-06-13 09:24:25 PDT 
Created attachment 204622 [details]
Patch
Comment 3 Brent Fulgham 2013-06-13 10:03:58 PDT 
Committed r151557: <http://trac.webkit.org/changeset/151557>