WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
109628
RenderQuote and RenderCounter should use tasks called before checking needsLayout()
https://bugs.webkit.org/show_bug.cgi?id=109628
Summary
RenderQuote and RenderCounter should use tasks called before checking needsLa...
Elliott Sprehn
Reported
2013-02-12 16:27:35 PST
Instead of dirtying the needsLayout bits during layout like in RenderQuote::updateDepth() we should instead use some kind of pre-layout like task. Unfortunately running before a layout is not quite enough, we instead need to run anytime someone would check needsLayout() to guard a call to layout() ex. Document::updateLayout() needs this.
Attachments
Add attachment
proposed patch, testcase, etc.
Elliott Sprehn
Comment 1
2013-02-12 16:29:52 PST
Note that the reason for this more complicated approach than the current proposal for pre-layout tasks is that RenderView may not need a layout, but there may be some pre-layout tasks that need to run that would then mark it as needing layout so: if (needsLayout()) layout(); void layout() { // not enough! Since we'll never even get here if needsLayout was false. preLayoutTasks(); realLayout(); }
Elliott Sprehn
Comment 2
2013-02-12 16:30:49 PST
Related bug:
https://bugs.webkit.org/show_bug.cgi?id=109616
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug