Bug 109623 - Fix signedness in WebTestProxy
Summary: Fix signedness in WebTestProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 15:31 PST by Alec Flett
Modified: 2013-02-12 15:54 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2013-02-12 15:33 PST, Alec Flett
no flags Details | Formatted Diff | Diff
Patch for landing (1.63 KB, patch)
2013-02-12 15:37 PST, Alec Flett
no flags Details | Formatted Diff | Diff
Patch for landing (1.58 KB, patch)
2013-02-12 15:39 PST, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2013-02-12 15:31:55 PST
Fix signedness in WebTestProxy
Comment 1 Alec Flett 2013-02-12 15:33:20 PST
Created attachment 187949 [details]
Patch
Comment 2 Adam Barth 2013-02-12 15:33:57 PST
Comment on attachment 187949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187949&action=review

> Tools/ChangeLog:19
> +2013-02-12  Alec Flett  <alecflett@chromium.org>
> +
> +        Fix signedness in WebTestProxy
> +        https://bugs.webkit.org/show_bug.cgi?id=109623
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix signedness problem, using size_t instead of int.
> +
> +        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
> +
> +2013-02-12  Alec Flett  <alecflett@chromium.org>
> +
> +        Fix signedness in WebTestProxy
> +        https://bugs.webkit.org/show_bug.cgi?id=109623
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

You have a goofy looking changelog
Comment 3 Alec Flett 2013-02-12 15:37:59 PST
Created attachment 187950 [details]
Patch for landing
Comment 4 Alec Flett 2013-02-12 15:39:50 PST
Created attachment 187952 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-02-12 15:54:38 PST
Comment on attachment 187952 [details]
Patch for landing

Clearing flags on attachment: 187952

Committed r142684: <http://trac.webkit.org/changeset/142684>
Comment 6 WebKit Review Bot 2013-02-12 15:54:41 PST
All reviewed patches have been landed.  Closing bug.