Bug 109615 – Add skeleton of the OfflineStorageProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Add skeleton of the OfflineStorageProcess

[Sam Weinig]

Created attachment 187935 [details]
Patch

[Adam Barth]

Comment on attachment 187935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187935&action=review

> Source/WebKit2/ChangeLog:7
> +
> +        Add skeleton of the OfflineStorageProcess
> +        https://bugs.webkit.org/show_bug.cgi?id=109615
> +
> +        Reviewed by NOBODY (OOPS!).
> +

This ChangeLog doesn't really give any information about what an OfflineStorageProcess is...

[Adam Barth]

What is an OfflineStorageProcess?  Generally, we ask that contributors explain the "why" behind their changes in the ChangeLog.

[Sam Weinig]

(In reply to comment #3)
> What is an OfflineStorageProcess?  Generally, we ask that contributors explain the "why" behind their changes in the ChangeLog.

I thought it was pretty self evident, but I can certainly go into more detail.  The idea is to have a process for offline storage activities, such as Databases and Local Storage.  We don't want to do this in our UI Process, because we can tightly sandbox these filesystem touching activities if they are in their own little world.

[Anders Carlsson]

Comment on attachment 187935 [details]
Patch

r=me with a more descriptive ChangeLog as Adam suggested.

[Sam Weinig]

Committed r142690: <http://trac.webkit.org/changeset/142690>

[Adam Barth]

Ah, I think I was trying to read too much into the "offline" part of the name.  Thanks for the description.