Bug 109615 - Add skeleton of the OfflineStorageProcess
Summary: Add skeleton of the OfflineStorageProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 14:30 PST by Sam Weinig
Modified: 2013-02-12 19:22 PST (History)
1 user (show)

See Also:


Attachments
Patch (133.82 KB, patch)
2013-02-12 14:32 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-02-12 14:30:11 PST
Add skeleton of the OfflineStorageProcess
Comment 1 Sam Weinig 2013-02-12 14:32:17 PST
Created attachment 187935 [details]
Patch
Comment 2 Adam Barth 2013-02-12 15:15:40 PST
Comment on attachment 187935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187935&action=review

> Source/WebKit2/ChangeLog:7
> +
> +        Add skeleton of the OfflineStorageProcess
> +        https://bugs.webkit.org/show_bug.cgi?id=109615
> +
> +        Reviewed by NOBODY (OOPS!).
> +

This ChangeLog doesn't really give any information about what an OfflineStorageProcess is...
Comment 3 Adam Barth 2013-02-12 15:16:14 PST
What is an OfflineStorageProcess?  Generally, we ask that contributors explain the "why" behind their changes in the ChangeLog.
Comment 4 Sam Weinig 2013-02-12 16:53:02 PST
(In reply to comment #3)
> What is an OfflineStorageProcess?  Generally, we ask that contributors explain the "why" behind their changes in the ChangeLog.

I thought it was pretty self evident, but I can certainly go into more detail.  The idea is to have a process for offline storage activities, such as Databases and Local Storage.  We don't want to do this in our UI Process, because we can tightly sandbox these filesystem touching activities if they are in their own little world.
Comment 5 Anders Carlsson 2013-02-12 16:54:59 PST
Comment on attachment 187935 [details]
Patch

r=me with a more descriptive ChangeLog as Adam suggested.
Comment 6 Sam Weinig 2013-02-12 16:59:30 PST
Committed r142690: <http://trac.webkit.org/changeset/142690>
Comment 7 Adam Barth 2013-02-12 19:22:15 PST
Ah, I think I was trying to read too much into the "offline" part of the name.  Thanks for the description.