Bug 109611 - [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents
Summary: [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sadrul Habib Chowdhury
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 13:59 PST by Sadrul Habib Chowdhury
Modified: 2013-02-13 08:26 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.46 KB, patch)
2013-02-12 14:03 PST, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2013-02-12 14:09 PST, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff
Patch (2.47 KB, patch)
2013-02-12 19:36 PST, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sadrul Habib Chowdhury 2013-02-12 13:59:27 PST
[chromium] Add unaccelerated deltas to WebMouseWheelEvent
Comment 1 Sadrul Habib Chowdhury 2013-02-12 14:03:06 PST
Created attachment 187929 [details]
Patch
Comment 2 Adam Barth 2013-02-12 14:05:51 PST
Comment on attachment 187929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187929&action=review

> Source/WebKit/chromium/ChangeLog:6
> +        Mousewheel events generated by trackpad can have accelrated deltas (e.g. when doing

typo: accelrated
Comment 3 WebKit Review Bot 2013-02-12 14:07:28 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Sadrul Habib Chowdhury 2013-02-12 14:09:30 PST
Created attachment 187932 [details]
Patch
Comment 5 Sadrul Habib Chowdhury 2013-02-12 14:10:04 PST
Comment on attachment 187929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187929&action=review

>> Source/WebKit/chromium/ChangeLog:6
>> +        Mousewheel events generated by trackpad can have accelrated deltas (e.g. when doing
> 
> typo: accelrated

Whoops. Fixed.
Comment 6 Adam Barth 2013-02-12 15:13:54 PST
Comment on attachment 187932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187932&action=review

> Source/WebKit/chromium/public/WebInputEvent.h:371
> +    float unacceleratedDeltaX;
> +    float unacceleratedDeltaY;

Should we add some comments explaining the difference between unacceleratedDeltaX and deltaX?  Does deltaX/unacceleratedDeltaX always equal deltaY/unacceleratedDeltaY?  If so, should we ASSERT that somewhere?  Should we just supply the ratio instead?
Comment 7 Sadrul Habib Chowdhury 2013-02-12 19:36:16 PST
Created attachment 187993 [details]
Patch
Comment 8 Sadrul Habib Chowdhury 2013-02-12 19:37:17 PST
Comment on attachment 187932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187932&action=review

>> Source/WebKit/chromium/public/WebInputEvent.h:371
>> +    float unacceleratedDeltaY;
> 
> Should we add some comments explaining the difference between unacceleratedDeltaX and deltaX?  Does deltaX/unacceleratedDeltaX always equal deltaY/unacceleratedDeltaY?  If so, should we ASSERT that somewhere?  Should we just supply the ratio instead?

Using the ratio sounds much better! Thanks! I have changed to use that.
Comment 9 Adam Barth 2013-02-12 19:52:52 PST
Does the ratio apply to the wheel ticks as well?
Comment 10 Sadrul Habib Chowdhury 2013-02-12 20:07:40 PST
(In reply to comment #9)
> Does the ratio apply to the wheel ticks as well?

Indeed it does. (wheelTicksX/Y are often computed from deltaX/Y)
Comment 11 WebKit Review Bot 2013-02-13 08:26:44 PST
Comment on attachment 187993 [details]
Patch

Clearing flags on attachment: 187993

Committed r142752: <http://trac.webkit.org/changeset/142752>
Comment 12 WebKit Review Bot 2013-02-13 08:26:48 PST
All reviewed patches have been landed.  Closing bug.