WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
109610
Move ElementAttributeData into Element.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=109610
Summary
Move ElementAttributeData into Element.cpp/h
Andreas Kling
Reported
2013-02-12 13:40:52 PST
ElementAttributeData is really just a slightly-less-than-dumb container that holds data for Element. I envision a future where Element is the only client of this class. As a first step, let's move the class into Element.h/cpp.
Attachments
Patch
(44.91 KB, patch)
2013-02-12 13:46 PST
,
Andreas Kling
andersca
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Patch for landing
(
deleted
)
2013-02-12 15:53 PST
,
Andreas Kling
kling
: commit-queue+
Details
Formatted Diff
Diff
Patch for landing
(45.93 KB, patch)
2013-02-12 16:18 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-02-12 13:46:19 PST
Created
attachment 187925
[details]
Patch
WebKit Review Bot
Comment 2
2013-02-12 14:29:44 PST
Comment on
attachment 187925
[details]
Patch
Attachment 187925
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/16513403
WebKit Review Bot
Comment 3
2013-02-12 14:50:06 PST
Comment on
attachment 187925
[details]
Patch
Attachment 187925
[details]
did not pass cr-linux-debug-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/16444492
Peter Beverloo (cr-android ews)
Comment 4
2013-02-12 15:10:56 PST
Comment on
attachment 187925
[details]
Patch
Attachment 187925
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/16440447
Andreas Kling
Comment 5
2013-02-12 15:53:50 PST
Created
attachment 187953
[details]
Patch for landing
Andreas Kling
Comment 6
2013-02-12 16:18:34 PST
Created
attachment 187958
[details]
Patch for landing
WebKit Review Bot
Comment 7
2013-02-12 17:45:33 PST
Comment on
attachment 187958
[details]
Patch for landing Clearing flags on attachment: 187958 Committed
r142698
: <
http://trac.webkit.org/changeset/142698
>
WebKit Review Bot
Comment 8
2013-02-12 17:45:38 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug