Bug 109608 - [BlackBerry] Eliminate the direct rendering option
Summary: [BlackBerry] Eliminate the direct rendering option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 13:16 PST by Jakob Petsovits
Modified: 2013-02-12 15:10 PST (History)
6 users (show)

See Also:

Attachments
Patch (42.74 KB, patch)
2013-02-12 13:19 PST, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
Patch with more boring commit message (42.89 KB, patch)
2013-02-12 13:53 PST, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2013-02-12 13:16:05 PST 
Direct rendering adds a lot of complexity and we're not going to use it anymore, ever. Death to blitting on the WebKit thread!

The patch below removes all traces of it from WebKit/blackberry. Also tracked as internal PR 293298.
Comment 1 Jakob Petsovits 2013-02-12 13:19:32 PST 
Created attachment 187918 [details]
Patch
Comment 2 Rob Buis 2013-02-12 13:46:09 PST 
Comment on attachment 187918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187918&action=review

> Source/WebKit/blackberry/ChangeLog:11
> +        anymore, ever. Death to blitting on the WebKit thread!

Please make a factual commit message.
Comment 3 Jakob Petsovits 2013-02-12 13:53:33 PST 
Created attachment 187926 [details]
Patch with more boring commit message

Something more like this?
Comment 4 Rob Buis 2013-02-12 14:05:09 PST 
Comment on attachment 187926 [details]
Patch with more boring commit message

LGTM.
Comment 5 WebKit Review Bot 2013-02-12 15:10:49 PST 
Comment on attachment 187926 [details]
Patch with more boring commit message

Clearing flags on attachment: 187926

Committed r142677: <http://trac.webkit.org/changeset/142677>
Comment 6 WebKit Review Bot 2013-02-12 15:10:53 PST 
All reviewed patches have been landed.  Closing bug.