RESOLVED INVALID 109590
Web Inspector: [DTE] goto matching brace functionality 
https://bugs.webkit.org/show_bug.cgi?id=109590
Summary Web Inspector: [DTE] goto matching brace functionality
Andrey Lushnikov
Reported 2013-02-12 08:52:27 PST
Implement "goto matching brace" functionality
Attachments
Patch (13.67 KB, patch)
2013-02-12 08:55 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (13.56 KB, patch)
2013-02-14 06:25 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (15.60 KB, patch)
2013-02-15 00:52 PST, Andrey Lushnikov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-02-12 08:55:54 PST
Created attachment 187878 [details] Patch
Build Bot
Comment 2 2013-02-12 20:27:04 PST
Comment on attachment 187878 [details] Patch Attachment 187878 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16513586 New failing tests: inspector/editor/text-editor-goto-matching-brace.html
Build Bot
Comment 3 2013-02-13 00:34:17 PST
Comment on attachment 187878 [details] Patch Attachment 187878 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16527018 New failing tests: inspector/editor/text-editor-goto-matching-brace.html
Andrey Lushnikov
Comment 4 2013-02-14 06:25:55 PST
Created attachment 188336 [details] Patch
Andrey Lushnikov
Comment 5 2013-02-14 06:50:57 PST
Due to brace matcher implementation, this version of "goto matching brace" won't actually go to matching brace if it wasn't highlighted. Not sure if it should be landed before braceMatcher will be fixed.
Build Bot
Comment 6 2013-02-14 19:01:45 PST
Comment on attachment 188336 [details] Patch Attachment 188336 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16542856 New failing tests: inspector/editor/text-editor-goto-matching-brace.html
Andrey Lushnikov
Comment 7 2013-02-15 00:52:35 PST
Created attachment 188501 [details] Patch
Brian Burg
Comment 8 2014-12-12 13:41:31 PST
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.
Note You need to log in before you can comment on or make changes to this bug.