Bug 109545 - DFG CompareEq optimization should be retuned
Summary: DFG CompareEq optimization should be retuned
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 22:00 PST by Filip Pizlo
Modified: 2013-02-12 09:35 PST (History)
7 users (show)

See Also:


Attachments
the patch (36.91 KB, patch)
2013-02-11 23:17 PST, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-02-11 22:00:03 PST
Couple of things seem to have gone wrong:

- Backend still emits checks even if the CFA has proven them to be unnecessary

- Object-to-object comparisons seem to no longer be emitted
Comment 1 Oliver Hunt 2013-02-11 22:06:35 PST
(In reply to comment #0)
> Couple of things seem to have gone wrong:
> 
> - Backend still emits checks even if the CFA has proven them to be unnecessary
> 
> - Object-to-object comparisons seem to no longer be emitted

inverted branch? :-D
Comment 2 Filip Pizlo 2013-02-11 22:07:33 PST
(In reply to comment #1)
> (In reply to comment #0)
> > Couple of things seem to have gone wrong:
> > 
> > - Backend still emits checks even if the CFA has proven them to be unnecessary
> > 
> > - Object-to-object comparisons seem to no longer be emitted
> 
> inverted branch? :-D

Affirmative.
Comment 3 Filip Pizlo 2013-02-11 23:17:03 PST
Created attachment 187779 [details]
the patch
Comment 4 Mark Hahnenberg 2013-02-12 08:56:45 PST
Comment on attachment 187779 [details]
the patch

r=me
Comment 5 Filip Pizlo 2013-02-12 09:35:54 PST
Landed in http://trac.webkit.org/changeset/142636