Bug 109542 - JSObject for ChannelSplitterNode and ChannelMergerNode are not created
Summary: JSObject for ChannelSplitterNode and ChannelMergerNode are not created
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 21:11 PST by Praveen Jadhav
Modified: 2013-02-13 22:05 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2013-02-13 20:45 PST, Praveen Jadhav 		no flags Details | Formatted Diff | Diff
Patch (5.46 KB, text/plain)
2013-02-13 21:42 PST, Praveen Jadhav 		no flags Details
Patch (5.46 KB, patch)
2013-02-13 21:43 PST, Praveen Jadhav 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Praveen Jadhav 2013-02-11 21:11:14 PST 
IDL files of ChannelSplitterNode and ChannelMergerNode in WebAudio don't include "JSGenerateToJSObject". As a result, Objects of base class AudioNode is created even if html expects ChannelSplitterNode and ChannelMergerNode respectively. We are not sure if this is intentional. Please clarify.
Comment 1 Praveen Jadhav 2013-02-13 20:45:27 PST 
Created attachment 188256 [details]
Patch

IDL file is updated to make sure JSObjects of ChannelSplitterNode and ChannelMergerNode are created.
Comment 2 Kentaro Hara 2013-02-13 20:46:35 PST 
Comment on attachment 188256 [details]
Patch

The change looks reasonable. Would you add a test for it?
Comment 3 Praveen Jadhav 2013-02-13 21:42:29 PST 
Created attachment 188259 [details]
Patch
Comment 4 Praveen Jadhav 2013-02-13 21:43:31 PST 
Created attachment 188260 [details]
Patch

Patch updated with LayoutTests.
Comment 5 Kentaro Hara 2013-02-13 21:45:06 PST 
Comment on attachment 188260 [details]
Patch

Looks good. Thanks.
Comment 6 WebKit Review Bot 2013-02-13 22:05:52 PST 
Comment on attachment 188260 [details]
Patch

Clearing flags on attachment: 188260

Committed r142848: <http://trac.webkit.org/changeset/142848>
Comment 7 WebKit Review Bot 2013-02-13 22:05:58 PST 
All reviewed patches have been landed.  Closing bug.