Bug 109534 - Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
Summary: Disable delete button controller on non-Mac ports and delete EditorClient::sh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 109517 109557
Blocks: 109549
  Show dependency tree / graph
 
Reported: 2013-02-11 18:38 PST by Ryosuke Niwa
Modified: 2013-02-12 08:47 PST (History)
16 users (show)

See Also:

Attachments
Disables the feature on non-Mac ports (28.13 KB, patch)
2013-02-11 18:38 PST, Ryosuke Niwa 		andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-02-11 18:38:05 PST 
Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
Comment 1 Ryosuke Niwa 2013-02-11 18:38:42 PST 
Created attachment 187748 [details]
Disables the feature on non-Mac ports
Comment 2 Martin Robinson 2013-02-11 19:20:25 PST 
The GTK+ bits look good!
Comment 3 Build Bot 2013-02-11 20:13:13 PST 
Comment on attachment 187748 [details]
Disables the feature on non-Mac ports

Attachment 187748 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16492584
Comment 4 Anders Carlsson 2013-02-11 20:33:27 PST 
Comment on attachment 187748 [details]
Disables the feature on non-Mac ports

View in context: https://bugs.webkit.org/attachment.cgi?id=187748&action=review

> Source/WebCore/editing/DeleteButtonController.cpp:285
> +    EditorClient* clinet = m_frame->editor()->client();

clinet -> client.
Comment 5 Ryosuke Niwa 2013-02-11 20:57:04 PST 
Committed r142576: <http://trac.webkit.org/changeset/142576>
Comment 6 David Kilzer (:ddkilzer) 2013-02-12 08:47:20 PST 
(In reply to comment #5)
> Committed r142576: <http://trac.webkit.org/changeset/142576>

Follow-up build fix:

Committed r142629: < http://trac.webkit.org/changeset/142629>