Here's what I'm thinking: ElementAttributeData => ElementData MutableElementAttributeData => PrivateElementAttributeData ImmutableElementAttributeDat a=> SharableElementAttributeData Element::attributeData() -> Element::elementData() Element::mutableAttributeData() => Element::ensurePrivateElementData()
MutableElementAttributeData => PrivateElementData ImmutableElementAttributeData => SharableElementData Is what I meant, duh.
Created attachment 187739 [details] Patch
Comment on attachment 187739 [details] Patch Attachment 187739 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16487609
Created attachment 187753 [details] Patch
Comment on attachment 187753 [details] Patch Attachment 187753 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16489683
Comment on attachment 187753 [details] Patch Actually, let's move stuff to Element.h/cpp first so we get as much version control history as possible.
Created attachment 188108 [details] Patch
Created attachment 188134 [details] Patch
Comment on attachment 188134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188134&action=review > Source/WebCore/ChangeLog:17 > + - MutableElementAttributeData => PrivateElementData "Private" is bit overloaded and does not pair that well with "shareable". Maybe "unique"?
Created attachment 188144 [details] Patch Yeah okay, "Unique" is nice.
Committed r142791: <http://trac.webkit.org/changeset/142791>