RESOLVED FIXED 109523
[V8] ScheduledAction::m_context can be empty, so we shouldn't retrieve an Isolate by using m_context->GetIsolate() 
https://bugs.webkit.org/show_bug.cgi?id=109523
Summary [V8] ScheduledAction::m_context can be empty, so we shouldn't retrieve an Iso...
Kentaro Hara
Reported 2013-02-11 17:08:39 PST
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate(). This can crash because ScheduledAction::m_context can be empty. Specifically, ScheduledAction::m_context is set to ScriptController::currentWorldContext(), which can return an empty handle when a frame does not exist. In addition, 'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty. Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.
Attachments
Patch (7.95 KB, patch)
2013-02-11 17:11 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-11 17:11:54 PST
Created attachment 187730 [details] Patch
Adam Barth
Comment 2 2013-02-11 17:17:02 PST
Comment on attachment 187730 [details] Patch ok
Kentaro Hara
Comment 3 2013-02-11 17:17:28 PST
Comment on attachment 187730 [details] Patch Thanks!
WebKit Review Bot
Comment 4 2013-02-11 18:07:51 PST
Comment on attachment 187730 [details] Patch Clearing flags on attachment: 187730 Committed r142565: <http://trac.webkit.org/changeset/142565>
WebKit Review Bot
Comment 5 2013-02-11 18:07:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.