Bug 109508 - WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
Summary: WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 15:59 PST by Kenneth Russell
Modified: 2013-02-11 16:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2013-02-11 16:28 PST, Zhenyao Mo 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2013-02-11 15:59:13 PST 
It's been pointed out by Evan Parker from the MapsGL team that getExtension("WEBGL_compressed_texture_s3tc") is returning a non-null value even when the underlying hardware doesn't support the extension. A supports() check in getExtension is missing.
Comment 1 Zhenyao Mo 2013-02-11 16:28:13 PST 
Created attachment 187716 [details]
Patch
Comment 2 Kenneth Russell 2013-02-11 16:31:24 PST 
Comment on attachment 187716 [details]
Patch

Thanks for the quick fix. Looks good. Note for the record that this will eventually be covered by the WebGL conformance tests Gregg Tavares is in the process of importing.
Comment 3 WebKit Review Bot 2013-02-11 16:32:46 PST 
Attachment 187716 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp']" exit_code: 1
Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2409:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2410:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Zhenyao Mo 2013-02-11 16:32:56 PST 
Committed r142545: <http://trac.webkit.org/changeset/142545>