Bug 109490 - webkit-patch's --reviewer flag should automatically convert emails to full names
Summary: webkit-patch's --reviewer flag should automatically convert emails to full names
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 14:28 PST by Michelangelo De Simone
Modified: 2013-02-11 15:20 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michelangelo De Simone 2013-02-11 14:28:42 PST 
When landing with land-safely --reviewer="SOMETHING" the SOMETHING token seems to be taken literally.

TO REPRODUCE:
Try to land a patch with webkit-patch land-safely --reviewer="somereviewer@webkit.org"

WHAT HAPPENS:
The ChangeLogs are populated with "Reviewed by somereviewer@webkit.org"

WHAT SHOULD HAPPEN INSTEAD
A reverse look-up of the --reviewer flag content should take place, populating the ChangeLogs with reviewer's FULL NAME.

NOTES:
For a picture of a great moment take a look at https://bugs.webkit.org/show_bug.cgi?id=106927