Bug 109483 – Fold MarkupTokenBase into HTMLToken now that it has no other subclasses

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Fold MarkupTokenBase into HTMLToken now that it has no other subclasses

[Eric Seidel (no email)]

Created attachment 187655 [details]
Patch

[Adam Barth]

Comment on attachment 187655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187655&action=review

> Source/WebCore/html/parser/HTMLToken.h:108
> +    /* Range and offset methods exposed for HTMLSourceTracker and HTMLViewSourceParser */

C++ style comments?

> Source/WebCore/html/parser/HTMLToken.h:157
> +    /* DOCTYPE Tokens */

C++ comments...

[Eric Seidel (no email)]

Comment on attachment 187655 [details]
Patch

I will take this under careful advisement.

[Early Warning System Bot]

Comment on attachment 187655 [details]
Patch

Attachment 187655 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16491400

[Eric Seidel (no email)]

Created attachment 187660 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 187660 [details]
Patch for landing

Rejecting attachment 187660 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 187660, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
/track/WebVTTTokenizer.h.rej
patching file Source/WebCore/xml/parser/MarkupTokenBase.h
rm 'Source/WebCore/xml/parser/MarkupTokenBase.h'
patching file Source/WebCore/xml/parser/MarkupTokenizerBase.h
Hunk #1 FAILED at 28.
Hunk #2 FAILED at 55.
Hunk #3 FAILED at 206.
3 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/xml/parser/MarkupTokenizerBase.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16487483

[Eric Seidel (no email)]

Created attachment 187663 [details]
Patch for landing

[Eric Seidel (no email)]

Created attachment 187664 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 187664 [details]
Patch for landing

Clearing flags on attachment: 187664

Committed r142522: <http://trac.webkit.org/changeset/142522>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.