Bug 109481 - Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Summary: Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 13:28 PST by Zan Dobersek
Modified: 2013-02-12 03:07 PST (History)
11 users (show)

See Also:

Attachments
Patch (6.46 KB, patch)
2013-02-11 13:31 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (6.57 KB, patch)
2013-02-12 01:54 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-02-11 13:28:52 PST 
Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
Comment 1 Zan Dobersek 2013-02-11 13:31:38 PST 
Created attachment 187652 [details]
Patch
Comment 2 Laszlo Gombos 2013-02-11 14:19:06 PST 
Comment on attachment 187652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review

Overall looks good.

> Tools/Scripts/webkitperl/FeatureList.pm:-481
> -    { option => "xhr-response-blob", desc => "Toggle XHR Response BLOB support",
> -      define => "ENABLE_XHR_RESPONSE_BLOB", default => isBlackBerry(), value => \$xhrResponseBlobSupport },
> -

I thing there is one more spot where xhrResponseBlobSupport is listed in FeatureList.pm.
Comment 3 Laszlo Gombos 2013-02-11 15:48:20 PST 
(In reply to comment #2)
> (From update of attachment 187652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review

> I thing there 

I think  .. :-)
Comment 4 Zan Dobersek 2013-02-12 01:43:13 PST 
Comment on attachment 187652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187652&action=review

>> Tools/Scripts/webkitperl/FeatureList.pm:-481
>> -
> 
> I thing there is one more spot where xhrResponseBlobSupport is listed in FeatureList.pm.

Ah, you're right. Will fix that.
Comment 5 Zan Dobersek 2013-02-12 01:54:32 PST 
Created attachment 187810 [details]
Patch
Comment 6 Zan Dobersek 2013-02-12 03:07:48 PST 
Comment on attachment 187810 [details]
Patch

Clearing flags on attachment: 187810

Committed r142600: <http://trac.webkit.org/changeset/142600>
Comment 7 Zan Dobersek 2013-02-12 03:07:55 PST 
All reviewed patches have been landed.  Closing bug.