Bug 109466 - [Mac] Track language selection should be sticky
Summary: [Mac] Track language selection should be sticky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-11 11:31 PST by Eric Carlson
Modified: 2013-02-11 22:33 PST (History)
11 users (show)

See Also:


Attachments
Proposed patch (33.02 KB, patch)
2013-02-11 12:32 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated: add missing export to autotools/symbols.filter (34.10 KB, patch)
2013-02-11 13:05 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Skip the new test on ports that don't have a caption menu (37.87 KB, patch)
2013-02-11 13:35 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Add the missing ';' (37.87 KB, patch)
2013-02-11 13:40 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Export Page::initGroup. (37.92 KB, patch)
2013-02-11 14:17 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-02-11 11:31:13 PST
Choosing a text track from the menu should make that track's language the preferred caption language. Turning captions off from the menu should disable captions in videos loaded subsequently. 

OS X has system support for these settings, so changes made by DRT should not change the settings on the user's system.
Comment 1 Radar WebKit Bug Importer 2013-02-11 11:32:09 PST
<rdar://problem/13191732>
Comment 2 Eric Carlson 2013-02-11 12:32:33 PST
Created attachment 187640 [details]
Proposed patch
Comment 3 Eric Carlson 2013-02-11 13:05:11 PST
Created attachment 187645 [details]
Updated: add missing export to autotools/symbols.filter
Comment 4 Philippe Normand 2013-02-11 13:32:31 PST
Comment on attachment 187645 [details]
Updated: add missing export to autotools/symbols.filter

View in context: https://bugs.webkit.org/attachment.cgi?id=187645&action=review

> Source/autotools/symbols.filter:268
> +_ZN7WebCore9PageGroup18captionPreferencesEv

Missing ; at the end of line
Comment 5 Eric Carlson 2013-02-11 13:35:50 PST
Created attachment 187654 [details]
Skip the new test on ports that don't have a caption menu
Comment 6 Eric Carlson 2013-02-11 13:40:46 PST
Created attachment 187656 [details]
Add the missing ';'
Comment 7 Eric Carlson 2013-02-11 14:03:15 PST
Philippe, do you know what symbol I need to export for WebCore::Page::initGroup() :

./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): In function `WebCore::Internals::resetToConsistentState(WebCore::Page*)':
Internals.cpp:(.text+0x3b0c): undefined reference to `WebCore::Page::initGroup()'
Comment 8 Philippe Normand 2013-02-11 14:13:04 PST
(In reply to comment #7)
> Philippe, do you know what symbol I need to export for WebCore::Page::initGroup() :
> 
> ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): In function `WebCore::Internals::resetToConsistentState(WebCore::Page*)':
> Internals.cpp:(.text+0x3b0c): undefined reference to `WebCore::Page::initGroup()'


initGroup is: _ZN7WebCore4Page9initGroupEv
Comment 9 Eric Carlson 2013-02-11 14:17:06 PST
Created attachment 187671 [details]
Export Page::initGroup.
Comment 10 Dean Jackson 2013-02-11 14:32:56 PST
Comment on attachment 187671 [details]
Export Page::initGroup.

View in context: https://bugs.webkit.org/attachment.cgi?id=187671&action=review

> Source/autotools/symbols.filter:269
> +_ZN7WebCore9PageGroup18captionPreferencesEv;
> +_ZN7WebCore4Page9initGroupEv;

You don't need to guard these with VIDEO_TRACK like in exp.in?

> LayoutTests/media/track/track-user-preferences.html:117
> +                    createTrackElements([ 'no', 'fr', 'en',]);

trailing comma

> LayoutTests/media/track/track-user-preferences.html:127
> +                    createTrackElements([ 'ru', 'jp', 'en',]);

trailing comma
Comment 11 Eric Carlson 2013-02-11 22:33:22 PST
Committed in http://trac.webkit.org/r142580