Bug 109466 – [Mac] Track language selection should be sticky

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Choosing a text track from the menu should make that track's language the preferred caption language. Turning captions off from the menu should disable captions in videos loaded subsequently. 

OS X has system support for these settings, so changes made by DRT should not change the settings on the user's system.

[Radar WebKit Bug Importer]

<rdar://problem/13191732>

[Eric Carlson]

Created attachment 187640 [details]
Proposed patch

[Eric Carlson]

Created attachment 187645 [details]
Updated: add missing export to autotools/symbols.filter

[Philippe Normand]

Comment on attachment 187645 [details]
Updated: add missing export to autotools/symbols.filter

View in context: https://bugs.webkit.org/attachment.cgi?id=187645&action=review

> Source/autotools/symbols.filter:268
> +_ZN7WebCore9PageGroup18captionPreferencesEv

Missing ; at the end of line

[Eric Carlson]

Created attachment 187654 [details]
Skip the new test on ports that don't have a caption menu

[Eric Carlson]

Created attachment 187656 [details]
Add the missing ';'

[Eric Carlson]

Philippe, do you know what symbol I need to export for WebCore::Page::initGroup() :

./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): In function `WebCore::Internals::resetToConsistentState(WebCore::Page*)':
Internals.cpp:(.text+0x3b0c): undefined reference to `WebCore::Page::initGroup()'

[Philippe Normand]

(In reply to comment #7)
> Philippe, do you know what symbol I need to export for WebCore::Page::initGroup() :
> 
> ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): In function `WebCore::Internals::resetToConsistentState(WebCore::Page*)':
> Internals.cpp:(.text+0x3b0c): undefined reference to `WebCore::Page::initGroup()'


initGroup is: _ZN7WebCore4Page9initGroupEv

[Eric Carlson]

Created attachment 187671 [details]
Export Page::initGroup.

[Dean Jackson]

Comment on attachment 187671 [details]
Export Page::initGroup.

View in context: https://bugs.webkit.org/attachment.cgi?id=187671&action=review

> Source/autotools/symbols.filter:269
> +_ZN7WebCore9PageGroup18captionPreferencesEv;
> +_ZN7WebCore4Page9initGroupEv;

You don't need to guard these with VIDEO_TRACK like in exp.in?

> LayoutTests/media/track/track-user-preferences.html:117
> +                    createTrackElements([ 'no', 'fr', 'en',]);

trailing comma

> LayoutTests/media/track/track-user-preferences.html:127
> +                    createTrackElements([ 'ru', 'jp', 'en',]);

trailing comma

[Eric Carlson]

Committed in http://trac.webkit.org/r142580