Bug 109459 – [iOS] Upstream changes to Platform.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[David Kilzer (:ddkilzer)]

Upstream iOS changes to Platform.h.

[David Kilzer (:ddkilzer)]

Created attachment 187610 [details]
Patch v1

[Laszlo Gombos]

Comment on attachment 187610 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review

> Source/WTF/wtf/Platform.h:-621
> -#if PLATFORM(IOS_SIMULATOR)
> -    #define ENABLE_JIT 0
> -    #define ENABLE_YARR_JIT 0

Is the intention to turn on JIT for the simulator as well ? If it is, the patch looks good to me.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> (From update of attachment 187610 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review
> 
> > Source/WTF/wtf/Platform.h:-621
> > -#if PLATFORM(IOS_SIMULATOR)
> > -    #define ENABLE_JIT 0
> > -    #define ENABLE_YARR_JIT 0
> 
> Is the intention to turn on JIT for the simulator as well ? If it is, the patch looks good to me.

Yes.

[Benjamin Poulain]

Comment on attachment 187610 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review

> Source/WTF/wtf/Platform.h:624
>  

Remove the blank line.

> Source/WTF/wtf/Platform.h:627
> +#define ENABLE_JIT 1
> +#define ENABLE_LLINT 1
> +#define ENABLE_YARR_JIT 1

Move those 3 ENABLE with the ones above?

> Source/WTF/wtf/Platform.h:1131
> +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000 || PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080

I'd just add parenthesis here for readability.

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> (From update of attachment 187610 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review
> 
> > Source/WTF/wtf/Platform.h:624
> >  
> 
> Remove the blank line.

Okay.

> > Source/WTF/wtf/Platform.h:627
> > +#define ENABLE_JIT 1
> > +#define ENABLE_LLINT 1
> > +#define ENABLE_YARR_JIT 1
> 
> Move those 3 ENABLE with the ones above?

Actually, all of these are defined below, so they should probably just be removed for "clarity".  (I don't find the definitions below very easy to follow, but better to match other platforms.)

> > Source/WTF/wtf/Platform.h:1131
> > +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000 || PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
> 
> I'd just add parenthesis here for readability.

Will do.

Thanks!

[David Kilzer (:ddkilzer)]

Committed r142537: <http://trac.webkit.org/changeset/142537>