Bug 109458 – RunQtAPITests failure of buildbot

• Status: RESOLVED
• Resolution: INVALID
• Component: JavaScriptCore

[Balazs Kilvady]

Uploaded archive of compiled webkit for Qt contains only /lib and /bin subdirectories while on Qt platform the WebKitBuild/Release/Source/WebKit/qt/tests/ directory is required by RunQtAPITests step. Without adding that directory to the archive on the tester slave we receive the following error:
ERROR:Options:Path 'WebKitBuild/Release/Source/WebKit/qt/tests/' doesn't exist

[Balazs Kilvady]

Created attachment 187606 [details]
proposed patch.

[Jocelyn Turcotte]

Comment on attachment 187606 [details]
proposed patch.

That might be a silly idea, but how about having those tests binaries targetted in bin directly instead of Release/Source/WebKit/qt? This would also make the test binaries easier to run.

The issue I see with this patch is that all objects files under Source/WebKit/qt will also be copied in the archive.

[Balazs Kilvady]

(In reply to comment #2)
> (From update of attachment 187606 [details])
> That might be a silly idea, but how about having those tests binaries targetted in bin directly instead of Release/Source/WebKit/qt? This would also make the test binaries easier to run.
> 
> The issue I see with this patch is that all objects files under Source/WebKit/qt will also be copied in the archive.

The .o files won't be in the archive. The script makes a copy of the binaries to compress and leaves out the object files. But I agree. I also think your idea would be better solution or there could be a /bin; /lib/; /qt-test-bin directory structure under Release/Debug directories.

[Anders Carlsson]

Comment on attachment 187606 [details]
proposed patch.

Qt has been removed, clearing review flags.