Bug 109443 - Web Inspector: [Extensions API] expose ExtensionServerClient to tests so tests use same port as extensions API
Summary: Web Inspector: [Extensions API] expose ExtensionServerClient to tests so test...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 08:39 PST by Andrey Kosyakov
Modified: 2013-02-11 10:02 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.60 KB, patch)
2013-02-11 08:42 PST, Andrey Kosyakov
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2013-02-11 08:39:12 PST
We currently have a separate message channel for evals in front-end context invoked from extension tests. This has negative impact on tests stability, as the message delivery order is not guaranteed for two different ports -- the extension output interleaving with front-end output (i.e. from console.log()) is a common source of flakiness. The proposed fix is to expose extensionServer to test code, so we can re-use the existing port and make sure test output is well serialized WRT extension commands.
Comment 1 Andrey Kosyakov 2013-02-11 08:42:50 PST
Created attachment 187580 [details]
Patch
Comment 2 Andrey Kosyakov 2013-02-11 10:02:59 PST
Committed r142485: <http://trac.webkit.org/changeset/142485>