Bug 109436 – [chromium] move printPage() implementation to testRunner library

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] move printPage() implementation to testRunner library

Created attachment 187571 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 187571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336
>  void WebViewHost::printPage(WebKit::WebFrame* frame)

Should we add an ASSERT_NOT_REACHED here?

Created attachment 187776 [details]
Patch for landing

(In reply to comment #3)
> (From update of attachment 187571 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review
> 
> > Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336
> >  void WebViewHost::printPage(WebKit::WebFrame* frame)
> 
> Should we add an ASSERT_NOT_REACHED here?

I just deleted the empty method

[WebKit Review Bot]

Comment on attachment 187776 [details]
Patch for landing

Clearing flags on attachment: 187776

Committed r142585: <http://trac.webkit.org/changeset/142585>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.