Bug 109436 - [chromium] move printPage() implementation to testRunner library
Summary: [chromium] move printPage() implementation to testRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 07:42 PST by jochen
Modified: 2013-02-11 23:20 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2013-02-11 07:43 PST, jochen
no flags Details | Formatted Diff | Diff
Patch for landing (5.12 KB, patch)
2013-02-11 22:59 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-11 07:42:49 PST
[chromium] move printPage() implementation to testRunner library
Comment 1 jochen 2013-02-11 07:43:00 PST
Created attachment 187571 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-11 07:50:57 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2013-02-11 10:39:20 PST
Comment on attachment 187571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336
>  void WebViewHost::printPage(WebKit::WebFrame* frame)

Should we add an ASSERT_NOT_REACHED here?
Comment 4 jochen 2013-02-11 22:59:15 PST
Created attachment 187776 [details]
Patch for landing
Comment 5 jochen 2013-02-11 22:59:27 PST
(In reply to comment #3)
> (From update of attachment 187571 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review
> 
> > Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336
> >  void WebViewHost::printPage(WebKit::WebFrame* frame)
> 
> Should we add an ASSERT_NOT_REACHED here?

I just deleted the empty method
Comment 6 WebKit Review Bot 2013-02-11 23:20:43 PST
Comment on attachment 187776 [details]
Patch for landing

Clearing flags on attachment: 187776

Committed r142585: <http://trac.webkit.org/changeset/142585>
Comment 7 WebKit Review Bot 2013-02-11 23:20:47 PST
All reviewed patches have been landed.  Closing bug.