RESOLVED FIXED 109433
Web Inspector: WebInspector.Project refactorings.
https://bugs.webkit.org/show_bug.cgi?id=109433
Summary Web Inspector: WebInspector.Project refactorings.
Vsevolod Vlasov
Reported 2013-02-11 07:15:38 PST
This change prepares Workspace and Project to migration to project-per-domain mode for network based projects. Renamed WebInspector.WorkspaceProvider to WebInspector.ProjectDelegate. Renamed Project.name() to Project.id() and delegated it to project delegate. Added Project.displayName() method that is delegated to project delegate.. SimpleWorkspaceProvider is now responsible for creation of SimpleWorkspaceDelegates and isolates various mappings from Project/ProjectDelegate concept. UISourceCode is now created based on path in the project. UISourceCode uri is now calculated based on project and path (right now uri is equal to path).
Attachments
Patch (64.81 KB, patch)
2013-02-11 07:19 PST, Vsevolod Vlasov
apavlov: review+
apavlov: commit-queue-
Vsevolod Vlasov
Comment 1 2013-02-11 07:19:21 PST
Alexander Pavlov (apavlov)
Comment 2 2013-02-11 07:35:13 PST
Comment on attachment 187568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187568&action=review > Source/WebCore/ChangeLog:11 > + Added Project.displayName() method that is delegated to project delegate.. Duplicate trailing . > Source/WebCore/inspector/front-end/UISourceCode.js:106 > + return this._path; Trailing whitespace > Source/WebCore/inspector/front-end/Workspace.js:166 > + type: function() Trailing whitespace > Source/WebCore/inspector/front-end/Workspace.js:223 > + return this._uiSourceCodes[path]; return ... || null; for the @return type conformance.
Vsevolod Vlasov
Comment 3 2013-02-11 07:52:25 PST
Note You need to log in before you can comment on or make changes to this bug.