RESOLVED FIXED 109432
Web Inspector: fix closure compiler warnings in the profiler code 
https://bugs.webkit.org/show_bug.cgi?id=109432
Summary Web Inspector: fix closure compiler warnings in the profiler code
Yury Semikhatsky
Reported 2013-02-11 07:15:24 PST
Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:500: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list function didReceiveMemorySnapshot(error, memoryBlock) ^ Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:678: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list function didReceiveMemorySnapshot(error, memoryBlock) ^ Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - mismatch of the addNativeSnapshotChunk property type and the type of the property it overrides from interface MemoryAgent.Dispatcher original: function (this:MemoryAgent.Dispatcher, (null|{baseToRealNodeId: (Array.<number>|null), edges: (Array.<number>|null), nodes: (Array.<number>|null), strings: (Array.<string>|null), ...})): undefined override: function (this:WebInspector.MemoryDispatcher, string): undefined addNativeSnapshotChunk: function(chunk) ^ Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - parameter uid does not appear in WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk's parameter list addNativeSnapshotChunk: function(chunk) ^
Attachments
Patch (2.29 KB, patch)
2013-02-11 07:16 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-02-11 07:16:41 PST
Created attachment 187567 [details] Patch
WebKit Review Bot
Comment 2 2013-02-11 07:47:25 PST
Comment on attachment 187567 [details] Patch Clearing flags on attachment: 187567 Committed r142473: <http://trac.webkit.org/changeset/142473>
WebKit Review Bot
Comment 3 2013-02-11 07:47:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.