Bug 109432 - Web Inspector: fix closure compiler warnings in the profiler code
Summary: Web Inspector: fix closure compiler warnings in the profiler code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 07:15 PST by Yury Semikhatsky
Modified: 2013-02-11 07:47 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2013-02-11 07:16 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-02-11 07:15:24 PST 
Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:500: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list
        function didReceiveMemorySnapshot(error, memoryBlock)
        ^

Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:678: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list
        function didReceiveMemorySnapshot(error, memoryBlock)
        ^

Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - mismatch of the addNativeSnapshotChunk property type and the type of the property it overrides from interface MemoryAgent.Dispatcher
original: function (this:MemoryAgent.Dispatcher, (null|{baseToRealNodeId: (Array.<number>|null), edges: (Array.<number>|null), nodes: (Array.<number>|null), strings: (Array.<string>|null), ...})): undefined
override: function (this:WebInspector.MemoryDispatcher, string): undefined
    addNativeSnapshotChunk: function(chunk)
    ^

Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - parameter uid does not appear in WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk's parameter list
    addNativeSnapshotChunk: function(chunk)
                            ^
Comment 1 Yury Semikhatsky 2013-02-11 07:16:41 PST 
Created attachment 187567 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-11 07:47:25 PST 
Comment on attachment 187567 [details]
Patch

Clearing flags on attachment: 187567

Committed r142473: <http://trac.webkit.org/changeset/142473>
Comment 3 WebKit Review Bot 2013-02-11 07:47:28 PST 
All reviewed patches have been landed.  Closing bug.