RESOLVED FIXED 109430
Web Inspector: separate SuggestBox from TextPrompt 
https://bugs.webkit.org/show_bug.cgi?id=109430
Summary Web Inspector: separate SuggestBox from TextPrompt
Andrey Lushnikov
Reported 2013-02-11 07:07:29 PST
Separate SuggestBox implementation from TextPrompt by the means of intermediate interface.
Attachments
Patch (9.09 KB, patch)
2013-02-12 02:35 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (34.55 KB, patch)
2013-02-12 04:29 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (34.60 KB, patch)
2013-02-12 05:01 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (34.60 KB, patch)
2013-02-12 05:28 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-02-12 02:35:41 PST
Created attachment 187816 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2013-02-12 04:05:24 PST
Comment on attachment 187816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187816&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:950 > +WebInspector.TextPrompt.SuggestBoxDelegate = function () extra whitespace before "()" > Source/WebCore/inspector/front-end/TextPrompt.js:954 > +WebInspector.TextPrompt.SuggestBoxDelegate.prototype = { This should rather be WebInspector.SuggestBoxDelegate, next to WebInspector.SuggestBox > Source/WebCore/inspector/front-end/TextPrompt.js:975 > +WebInspector.TextPrompt.SuggestBox = function(suggestBoxDelegate, inputElement, className) This should become WebInspector.SuggestBox, preferably in its own file
Andrey Lushnikov
Comment 3 2013-02-12 04:29:51 PST
Created attachment 187831 [details] Patch
Andrey Lushnikov
Comment 4 2013-02-12 05:01:32 PST
Created attachment 187836 [details] Patch
Andrey Lushnikov
Comment 5 2013-02-12 05:28:18 PST
Created attachment 187841 [details] Patch
WebKit Review Bot
Comment 6 2013-02-12 06:05:47 PST
Comment on attachment 187841 [details] Patch Clearing flags on attachment: 187841 Committed r142610: <http://trac.webkit.org/changeset/142610>
WebKit Review Bot
Comment 7 2013-02-12 06:05:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.