Bug 109430 - Web Inspector: separate SuggestBox from TextPrompt
Summary: Web Inspector: separate SuggestBox from TextPrompt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-11 07:07 PST by Andrey Lushnikov
Modified: 2013-02-12 06:05 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.09 KB, patch)
2013-02-12 02:35 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (34.55 KB, patch)
2013-02-12 04:29 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (34.60 KB, patch)
2013-02-12 05:01 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (34.60 KB, patch)
2013-02-12 05:28 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-11 07:07:29 PST 
Separate SuggestBox implementation from TextPrompt by the means of intermediate interface.
Comment 1 Andrey Lushnikov 2013-02-12 02:35:41 PST 
Created attachment 187816 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-12 04:05:24 PST 
Comment on attachment 187816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187816&action=review

> Source/WebCore/inspector/front-end/TextPrompt.js:950
> +WebInspector.TextPrompt.SuggestBoxDelegate = function ()

extra whitespace before "()"

> Source/WebCore/inspector/front-end/TextPrompt.js:954
> +WebInspector.TextPrompt.SuggestBoxDelegate.prototype = {

This should rather be WebInspector.SuggestBoxDelegate, next to WebInspector.SuggestBox

> Source/WebCore/inspector/front-end/TextPrompt.js:975
> +WebInspector.TextPrompt.SuggestBox = function(suggestBoxDelegate, inputElement, className)

This should become WebInspector.SuggestBox, preferably in its own file
Comment 3 Andrey Lushnikov 2013-02-12 04:29:51 PST 
Created attachment 187831 [details]
Patch
Comment 4 Andrey Lushnikov 2013-02-12 05:01:32 PST 
Created attachment 187836 [details]
Patch
Comment 5 Andrey Lushnikov 2013-02-12 05:28:18 PST 
Created attachment 187841 [details]
Patch
Comment 6 WebKit Review Bot 2013-02-12 06:05:47 PST 
Comment on attachment 187841 [details]
Patch

Clearing flags on attachment: 187841

Committed r142610: <http://trac.webkit.org/changeset/142610>
Comment 7 WebKit Review Bot 2013-02-12 06:05:52 PST 
All reviewed patches have been landed.  Closing bug.