Bug 109411 - Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase
Summary: Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 107522
  Show dependency treegraph
 
Reported: 2013-02-11 02:11 PST by Eric Seidel (no email)
Modified: 2013-02-11 12:43 PST (History)
9 users (show)

See Also:


Attachments
Patch (13.17 KB, patch)
2013-02-11 02:13 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (34.90 KB, patch)
2013-02-11 10:15 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (34.91 KB, patch)
2013-02-11 10:16 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (63.39 KB, patch)
2013-02-11 11:26 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (62.85 KB, patch)
2013-02-11 11:28 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (62.84 KB, patch)
2013-02-11 12:18 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-02-11 02:11:04 PST
Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase
Comment 1 Eric Seidel (no email) 2013-02-11 02:13:00 PST
Created attachment 187529 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-11 10:15:35 PST
Created attachment 187609 [details]
Patch
Comment 3 Eric Seidel (no email) 2013-02-11 10:16:58 PST
Created attachment 187612 [details]
Patch
Comment 4 kov's GTK+ EWS bot 2013-02-11 10:22:14 PST
Comment on attachment 187612 [details]
Patch

Attachment 187612 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16493297
Comment 5 WebKit Review Bot 2013-02-11 10:24:32 PST
Comment on attachment 187612 [details]
Patch

Attachment 187612 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16491307
Comment 6 Eric Seidel (no email) 2013-02-11 10:24:55 PST
Sigh.  I was too tricky for some compilers.  Will fix.
Comment 7 Tony Gentilcore 2013-02-11 10:27:30 PST
Comment on attachment 187612 [details]
Patch

Need to fix compilation. Else looks good.
Comment 8 Adam Barth 2013-02-11 10:52:14 PST
Comment on attachment 187612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187612&action=review

> Source/WebCore/html/parser/InputStreamPreprocessor.h:84
> +                if (m_tokenizer->shouldSkipNullCharacters()) {

Another option is to pass this bit in to peek rather than keeping a pointer to the tokenizer.  That would let your remove the template parameter.  Maybe in a followup patch?
Comment 9 Eric Seidel (no email) 2013-02-11 10:54:02 PST
Comment on attachment 187612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187612&action=review

>> Source/WebCore/html/parser/InputStreamPreprocessor.h:84
>> +                if (m_tokenizer->shouldSkipNullCharacters()) {
> 
> Another option is to pass this bit in to peek rather than keeping a pointer to the tokenizer.  That would let your remove the template parameter.  Maybe in a followup patch?

Yup.  This function is ridiculously hot, so I didn't want to add that overhead to every callsite in the chnace that it changed perf.  We can try it in a separate patch.
Comment 10 Eric Seidel (no email) 2013-02-11 11:26:14 PST
Created attachment 187623 [details]
Patch
Comment 11 Eric Seidel (no email) 2013-02-11 11:27:43 PST
Comment on attachment 187623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187623&action=review

> Source/WebCore/html/parser/HTMLInputStream.h:40
> +// The current segmented string is stored in InputStream. Each of afterInsertionPoint

Sublime got me.  Fixed.
Comment 12 Eric Seidel (no email) 2013-02-11 11:28:45 PST
Created attachment 187625 [details]
Patch
Comment 13 WebKit Review Bot 2013-02-11 11:40:28 PST
Comment on attachment 187625 [details]
Patch

Attachment 187625 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16448060
Comment 14 Eric Seidel (no email) 2013-02-11 12:18:47 PST
Created attachment 187637 [details]
Patch
Comment 15 WebKit Review Bot 2013-02-11 12:43:28 PST
Comment on attachment 187637 [details]
Patch

Clearing flags on attachment: 187637

Committed r142497: <http://trac.webkit.org/changeset/142497>
Comment 16 WebKit Review Bot 2013-02-11 12:43:33 PST
All reviewed patches have been landed.  Closing bug.