Bug 109410 - Move WebVTTToken off of MarkupTokenBase
Summary: Move WebVTTToken off of MarkupTokenBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 107522
  Show dependency treegraph
 
Reported: 2013-02-11 01:31 PST by Eric Seidel (no email)
Modified: 2013-02-11 10:43 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2013-02-11 01:33 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2013-02-11 01:43 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-02-11 01:31:49 PST
Move WebVTTToken off of MarkupTokenBase
Comment 1 Eric Seidel (no email) 2013-02-11 01:33:28 PST
Created attachment 187525 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-11 01:34:58 PST
After this lands, MarkupTokenBase will only be used by HTMLToken and thus can just be moved into HTMLToken.
Comment 3 Eric Seidel (no email) 2013-02-11 01:43:05 PST
Created attachment 187527 [details]
Patch
Comment 4 Tony Gentilcore 2013-02-11 09:48:11 PST
Comment on attachment 187527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review

> Source/WebCore/html/track/WebVTTToken.h:70
> +        return m_data;

Do we need to ASSERT the type is start or end tag here?
Comment 5 Eric Seidel (no email) 2013-02-11 09:51:20 PST
Comment on attachment 187527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review

>> Source/WebCore/html/track/WebVTTToken.h:70
>> +        return m_data;
> 
> Do we need to ASSERT the type is start or end tag here?

The old impl didn't, so I'm inclined to leave it off for now.  The goal was to maintain compat with the previous impl (while removing the dead code).
Comment 6 Tony Gentilcore 2013-02-11 09:52:17 PST
(In reply to comment #5)
> (From update of attachment 187527 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review
> 
> >> Source/WebCore/html/track/WebVTTToken.h:70
> >> +        return m_data;
> > 
> > Do we need to ASSERT the type is start or end tag here?
> 
> The old impl didn't, so I'm inclined to leave it off for now.  The goal was to maintain compat with the previous impl (while removing the dead code).

OK
Comment 7 WebKit Review Bot 2013-02-11 09:56:32 PST
Comment on attachment 187527 [details]
Patch

Clearing flags on attachment: 187527

Committed r142484: <http://trac.webkit.org/changeset/142484>
Comment 8 WebKit Review Bot 2013-02-11 09:56:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Adam Barth 2013-02-11 10:43:35 PST
Comment on attachment 187527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review

> Source/WebCore/html/track/WebVTTToken.h:206
> +    DataVector m_data;
>      DataVector m_annotation;
>      DataVector m_classes;
>      DataVector m_currentBuffer;

Wow that's a lot of storage!