Move WebVTTToken off of MarkupTokenBase
Created attachment 187525 [details] Patch
After this lands, MarkupTokenBase will only be used by HTMLToken and thus can just be moved into HTMLToken.
Created attachment 187527 [details] Patch
Comment on attachment 187527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review > Source/WebCore/html/track/WebVTTToken.h:70 > + return m_data; Do we need to ASSERT the type is start or end tag here?
Comment on attachment 187527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review >> Source/WebCore/html/track/WebVTTToken.h:70 >> + return m_data; > > Do we need to ASSERT the type is start or end tag here? The old impl didn't, so I'm inclined to leave it off for now. The goal was to maintain compat with the previous impl (while removing the dead code).
(In reply to comment #5) > (From update of attachment 187527 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review > > >> Source/WebCore/html/track/WebVTTToken.h:70 > >> + return m_data; > > > > Do we need to ASSERT the type is start or end tag here? > > The old impl didn't, so I'm inclined to leave it off for now. The goal was to maintain compat with the previous impl (while removing the dead code). OK
Comment on attachment 187527 [details] Patch Clearing flags on attachment: 187527 Committed r142484: <http://trac.webkit.org/changeset/142484>
All reviewed patches have been landed. Closing bug.
Comment on attachment 187527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187527&action=review > Source/WebCore/html/track/WebVTTToken.h:206 > + DataVector m_data; > DataVector m_annotation; > DataVector m_classes; > DataVector m_currentBuffer; Wow that's a lot of storage!