RESOLVED FIXED 109403
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests 
https://bugs.webkit.org/show_bug.cgi?id=109403
Summary [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_u...
James Robinson
Reported 2013-02-11 00:01:33 PST
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
Attachments
Patch (6.37 KB, patch)
2013-02-11 00:02 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (6.72 KB, patch)
2013-02-11 15:23 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-02-11 00:02:48 PST
Created attachment 187517 [details] Patch
James Robinson
Comment 2 2013-02-11 00:03:22 PST
Chromium side implementation is here: https://codereview.chromium.org/12211110/ Before that lands, this patch will compile but GraphicsLayerChromiumTest and ScrollingCoordinatorChromiumTest will fail.
WebKit Review Bot
Comment 3 2013-02-11 00:20:34 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 4 2013-02-11 00:51:50 PST
Comment on attachment 187517 [details] Patch Attachment 187517 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16491129
WebKit Review Bot
Comment 5 2013-02-11 00:57:17 PST
Comment on attachment 187517 [details] Patch Attachment 187517 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16498088
Peter Beverloo (cr-android ews)
Comment 6 2013-02-11 01:10:06 PST
Comment on attachment 187517 [details] Patch Attachment 187517 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16493112
James Robinson
Comment 7 2013-02-11 15:23:42 PST
Created attachment 187694 [details] Patch
James Robinson
Comment 8 2013-02-11 15:26:40 PST
The second patch adds a type enum. I want to use to this to provide compositing support to DumpRenderTree as well.
WebKit Review Bot
Comment 9 2013-02-11 15:56:58 PST
Comment on attachment 187694 [details] Patch Attachment 187694 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16497421
Peter Beverloo (cr-android ews)
Comment 10 2013-02-11 16:17:18 PST
Comment on attachment 187694 [details] Patch Attachment 187694 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16485624
WebKit Review Bot
Comment 11 2013-02-11 17:02:23 PST
Comment on attachment 187694 [details] Patch Attachment 187694 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16493491
Adam Barth
Comment 12 2013-02-11 17:15:20 PST
Comment on attachment 187694 [details] Patch Ok. You've got some red bots to work through.
James Robinson
Comment 13 2013-02-11 18:52:30 PST
Comment on attachment 187694 [details] Patch Clearing flags on attachment: 187694 Committed r142568: <http://trac.webkit.org/changeset/142568>
James Robinson
Comment 14 2013-02-11 18:52:34 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 15 2013-02-11 20:13:59 PST
Re-opened since this is blocked by bug 109541
James Robinson
Comment 16 2013-02-11 22:12:16 PST
(In reply to comment #15) > Re-opened since this is blocked by bug 109541 ASSERT_TRUE expands to a return statement, which doesn't work in a constructor. Not sure how this compiles sometimes.
James Robinson
Comment 17 2013-02-11 22:45:01 PST
Committed r142581: <http://trac.webkit.org/changeset/142581>
Note You need to log in before you can comment on or make changes to this bug.