Bug 109386 - gtk/DumpRenderTree.cpp is missing <locale.h> include
Summary: gtk/DumpRenderTree.cpp is missing <locale.h> include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-02-10 13:25 PST by Jeremy Huddleston Sequoia
Modified: 2013-02-21 09:54 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2013-02-10 13:25:35 PST 
DumpRenderTree.cpp uses setlocale() and LC_ALL.  You need to #include <locale.h> for that.

--- Tools/DumpRenderTree/gtk/DumpRenderTree.cpp.orig	2013-02-10 11:47:57.000000000 -0800
+++ Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2013-02-10 11:48:44.000000000 -0800
@@ -50,6 +50,7 @@
 #include <cstring>
 #include <getopt.h>
 #include <gtk/gtk.h>
+#include <locale.h>
 #include <webkit/webkit.h>
 #include <wtf/Assertions.h>
 #include <wtf/gobject/GOwnPtr.h>
Comment 1 Jeremy Huddleston Sequoia 2013-02-10 13:26:29 PST 
This is with 1.11.4
Comment 2 Martin Robinson 2013-02-21 09:54:39 PST 
Committed r143620: <http://trac.webkit.org/changeset/143620>