Bug 109381 - WKTR should propagate view creation options to opened windows
Summary: WKTR should propagate view creation options to opened windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-10 11:18 PST by Tim Horton
Modified: 2013-02-12 19:37 PST (History)
1 user (show)

See Also:


Attachments
patch (5.33 KB, patch)
2013-02-10 11:21 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-02-10 11:18:15 PST
The options dictionary is dropped on the floor for window.open'd windows, but it would be nice if it weren't.
Comment 1 Tim Horton 2013-02-10 11:21:45 PST
Created attachment 187487 [details]
patch
Comment 2 Simon Fraser (smfr) 2013-02-10 11:24:28 PST
Comment on attachment 187487 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187487&action=review

> Tools/ChangeLog:3
> +        WKTR should propagate view creation options to subviews

''to subviews isn't quite accurate. "to opened windows"?
Comment 3 Tim Horton 2013-02-10 11:25:42 PST
Yeah, it's a bit weird. I've been flopping between calling them subviews and subwindows :| It's really "to PlatformWebViews in subwindows". I'll go with "to opened windows". Thanks!
Comment 4 Tim Horton 2013-02-10 11:29:09 PST
http://trac.webkit.org/changeset/142412