RESOLVED FIXED 109377
[WK2][EFL] Cleanup of graphics related code in EwkView 
https://bugs.webkit.org/show_bug.cgi?id=109377
Summary [WK2][EFL] Cleanup of graphics related code in EwkView
Kenneth Rohde Christiansen
Reported 2013-02-10 05:51:58 PST
SSIA.
Attachments
Work in progress (16.63 KB, patch)
2013-02-10 05:55 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (17.91 KB, patch)
2013-02-11 08:53 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (17.93 KB, patch)
2013-02-12 08:26 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.98 KB, patch)
2013-02-13 09:00 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2013-02-10 05:55:50 PST
Created attachment 187479 [details] Work in progress
Kenneth Rohde Christiansen
Comment 2 2013-02-11 08:53:39 PST
Created attachment 187591 [details] Patch
Build Bot
Comment 3 2013-02-11 20:04:50 PST
Comment on attachment 187591 [details] Patch Attachment 187591 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16496563 New failing tests: http/tests/cache/cached-main-resource.html
Kenneth Rohde Christiansen
Comment 4 2013-02-12 05:25:27 PST
(In reply to comment #3) > (From update of attachment 187591 [details]) > Attachment 187591 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://queues.webkit.org/results/16496563 > > New failing tests: > http/tests/cache/cached-main-resource.html Unrelated
Chris Dumez
Comment 5 2013-02-12 05:35:17 PST
Comment on attachment 187591 [details] Patch LGTM.
Kenneth Rohde Christiansen
Comment 6 2013-02-12 08:26:05 PST
Created attachment 187872 [details] Patch
Mikhail Pozdnyakov
Comment 7 2013-02-12 08:33:47 PST
Comment on attachment 187872 [details] Patch looks nice
Gyuyoung Kim
Comment 8 2013-02-12 17:56:20 PST
Comment on attachment 187872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187872&action=review Looks nice too. > Source/WebKit2/UIProcess/API/efl/EwkView.h:80 > +class TransformationMatrix; Wrong alphabet order ?
Anders Carlsson
Comment 9 2013-02-13 08:49:29 PST
Comment on attachment 187872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187872&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.h:80 >> +class TransformationMatrix; > > Wrong alphabet order ? Yup, please fix.
Kenneth Rohde Christiansen
Comment 10 2013-02-13 09:00:09 PST
Created attachment 188092 [details] Patch for landing
WebKit Review Bot
Comment 11 2013-02-13 09:48:11 PST
Comment on attachment 188092 [details] Patch for landing Clearing flags on attachment: 188092 Committed r142758: <http://trac.webkit.org/changeset/142758>
WebKit Review Bot
Comment 12 2013-02-13 09:48:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.