Bug 109374 - [chromium] Fix Android scrollbar size
Summary: [chromium] Fix Android scrollbar size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-10 01:04 PST by Alexandre Elias
Modified: 2013-02-10 18:55 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.48 KB, patch)
2013-02-10 01:09 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch (3.48 KB, patch)
2013-02-10 17:58 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff
Patch for landing (3.48 KB, patch)
2013-02-10 18:00 PST, Alexandre Elias
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2013-02-10 01:04:47 PST
[chromium] Fix Android scrollbar size
Comment 1 Alexandre Elias 2013-02-10 01:09:46 PST
Created attachment 187469 [details]
Patch
Comment 2 Peter Beverloo (cr-android ews) 2013-02-10 01:21:47 PST
Comment on attachment 187469 [details]
Patch

Attachment 187469 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16468789
Comment 3 James Robinson 2013-02-10 13:48:59 PST
Comment on attachment 187469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187469&action=review

> Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:114
> +    context->fillRect(centerRect, Color(128, 128, 128, 128), ColorSpaceDeviceRGB);

as EWS points out, this doesn't compile.  What did you mean here instead of centerRect?  thumbRect ?
Comment 4 James Robinson 2013-02-10 13:50:35 PST
Comment on attachment 187469 [details]
Patch

Could you just extend the thumb rect out very slightly to get some edge AA?

R=me if you make it compile
Comment 5 Alexandre Elias 2013-02-10 17:58:07 PST
Created attachment 187502 [details]
Patch

Fix compile error (centerRect->thumbRect)
Comment 6 Alexandre Elias 2013-02-10 18:00:24 PST
Created attachment 187503 [details]
Patch for landing
Comment 7 Alexandre Elias 2013-02-10 18:12:08 PST
Just saw your edge AA comment.  Tien-Ren is reimplementing this to use SolidColorQuad (since scrollbar texture management is proving a pain) so let's revisit there.
Comment 8 WebKit Review Bot 2013-02-10 18:55:52 PST
Comment on attachment 187503 [details]
Patch for landing

Clearing flags on attachment: 187503

Committed r142423: <http://trac.webkit.org/changeset/142423>
Comment 9 WebKit Review Bot 2013-02-10 18:55:55 PST
All reviewed patches have been landed.  Closing bug.