Bug 109372 - Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions.
Summary: Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-09 23:31 PST by Mike West
Modified: 2013-02-11 05:52 PST (History)
10 users (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2013-02-09 23:32 PST, Mike West
no flags Details | Formatted Diff | Diff
Second time's the charm. (3.01 KB, patch)
2013-02-10 11:30 PST, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-02-09 23:31:13 PST
Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions.
Comment 1 Mike West 2013-02-09 23:32:35 PST
Created attachment 187467 [details]
Patch
Comment 2 Mike West 2013-02-09 23:33:31 PST
Hello Jochen! Here are moar trivial changes!
Comment 3 WebKit Review Bot 2013-02-09 23:37:38 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16470666
Comment 4 Early Warning System Bot 2013-02-09 23:37:51 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16471678
Comment 5 Early Warning System Bot 2013-02-09 23:39:37 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16479607
Comment 6 WebKit Review Bot 2013-02-09 23:41:01 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16471679
Comment 7 EFL EWS Bot 2013-02-09 23:41:16 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16467790
Comment 8 Build Bot 2013-02-09 23:46:21 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16470669
Comment 9 Mike West 2013-02-10 00:01:18 PST
*ahem* It's so trivial, it doesn't even compile.

I'll fix that, shall I?
Comment 10 Peter Beverloo (cr-android ews) 2013-02-10 00:19:17 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16468758
Comment 11 Build Bot 2013-02-10 00:23:52 PST
Comment on attachment 187467 [details]
Patch

Attachment 187467 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16469716
Comment 12 Mike West 2013-02-10 11:30:11 PST
Created attachment 187488 [details]
Second time's the charm.
Comment 13 Build Bot 2013-02-10 20:01:47 PST
Comment on attachment 187488 [details]
Second time's the charm.

Attachment 187488 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16479941

New failing tests:
compositing/checkerboard.html
accessibility/anchor-linked-anonymous-block-crash.html
http/tests/cache/cancel-multiple-post-xhrs.html
animations/3d/state-at-end-event-transform.html
animations/animation-add-events-in-handler.html
animations/3d/replace-filling-transform.html
http/tests/cache/history-only-cached-subresource-loads.html
compositing/bounds-in-flipped-writing-mode.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
accessibility/accessibility-object-detached.html
accessibility/anonymous-render-block-in-continuation-causes-crash.html
animations/animation-controller-drt-api.html
compositing/absolute-position-changed-with-composited-parent-layer.html
compositing/absolute-position-changed-in-composited-layer.html
http/tests/cache/iframe-304-crash.html
animations/3d/transform-perspective.html
http/tests/cache/cancel-during-failure-crash.html
canvas/philip/tests/2d.clearRect.basic.html
animations/3d/transform-origin-vs-functions.html
animations/animation-css-rule-types.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Comment 14 jochen 2013-02-11 05:14:55 PST
Comment on attachment 187488 [details]
Second time's the charm.

ok
Comment 15 WebKit Review Bot 2013-02-11 05:52:41 PST
Comment on attachment 187488 [details]
Second time's the charm.

Clearing flags on attachment: 187488

Committed r142459: <http://trac.webkit.org/changeset/142459>
Comment 16 WebKit Review Bot 2013-02-11 05:52:45 PST
All reviewed patches have been landed.  Closing bug.