Bug 109349 - Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
Summary: Kill TestRunner::setMinimumTimerInterval; implement the feature with Internal...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 22:14 PST by Benjamin Poulain
Modified: 2013-02-11 14:52 PST (History)
17 users (show)

See Also:

Attachments
Patch (45.55 KB, patch)
2013-02-08 22:23 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (46.81 KB, patch)
2013-02-08 22:37 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (46.79 KB, patch)
2013-02-10 13:27 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-02-08 22:14:14 PST 
Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
Comment 1 Benjamin Poulain 2013-02-08 22:23:09 PST 
Created attachment 187415 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 22:25:57 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Benjamin Poulain 2013-02-08 22:37:50 PST 
Created attachment 187417 [details]
Patch
Comment 4 James Robinson 2013-02-08 22:57:13 PST 
Comment on attachment 187417 [details]
Patch

Would r+ but I'm not allowed since this touches WebKit2
Comment 5 kov's GTK+ EWS bot 2013-02-08 23:08:11 PST 
Comment on attachment 187417 [details]
Patch

Attachment 187417 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16478072
Comment 6 Benjamin Poulain 2013-02-08 23:22:54 PST 
> (From update of attachment 187417 [details])
> Would r+ but I'm not allowed since this touches WebKit2

No problem. Thank for checking the Chromium changes are okay.
Comment 7 Benjamin Poulain 2013-02-10 13:27:52 PST 
Created attachment 187493 [details]
Patch
Comment 8 Benjamin Poulain 2013-02-11 13:42:33 PST 
Comment on attachment 187493 [details]
Patch

Clearing flags on attachment: 187493

Committed r142509: <http://trac.webkit.org/changeset/142509>
Comment 9 Benjamin Poulain 2013-02-11 13:42:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Roger Fong 2013-02-11 14:36:48 PST 
I believe this broke the Windows build here: 
http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/62268/steps/compile-webkit/logs/stdio
Comment 11 Benjamin Poulain 2013-02-11 14:40:23 PST 
(In reply to comment #10)
> I believe this broke the Windows build here: 
> http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/62268/steps/compile-webkit/logs/stdio

I'll update the symbols. The bot was not working previously.
Comment 12 Benjamin Poulain 2013-02-11 14:52:48 PST 
Windows symbols in http://trac.webkit.org/changeset/142519