RESOLVED FIXED 109349
Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings 
https://bugs.webkit.org/show_bug.cgi?id=109349
Summary Kill TestRunner::setMinimumTimerInterval; implement the feature with Internal...
Benjamin Poulain
Reported 2013-02-08 22:14:14 PST
Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
Attachments
Patch (45.55 KB, patch)
2013-02-08 22:23 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (46.81 KB, patch)
2013-02-08 22:37 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (46.79 KB, patch)
2013-02-10 13:27 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-02-08 22:23:09 PST
Created attachment 187415 [details] Patch
WebKit Review Bot
Comment 2 2013-02-08 22:25:57 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Benjamin Poulain
Comment 3 2013-02-08 22:37:50 PST
Created attachment 187417 [details] Patch
James Robinson
Comment 4 2013-02-08 22:57:13 PST
Comment on attachment 187417 [details] Patch Would r+ but I'm not allowed since this touches WebKit2
kov's GTK+ EWS bot
Comment 5 2013-02-08 23:08:11 PST
Comment on attachment 187417 [details] Patch Attachment 187417 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16478072
Benjamin Poulain
Comment 6 2013-02-08 23:22:54 PST
> (From update of attachment 187417 [details]) > Would r+ but I'm not allowed since this touches WebKit2 No problem. Thank for checking the Chromium changes are okay.
Benjamin Poulain
Comment 7 2013-02-10 13:27:52 PST
Created attachment 187493 [details] Patch
Benjamin Poulain
Comment 8 2013-02-11 13:42:33 PST
Comment on attachment 187493 [details] Patch Clearing flags on attachment: 187493 Committed r142509: <http://trac.webkit.org/changeset/142509>
Benjamin Poulain
Comment 9 2013-02-11 13:42:37 PST
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 10 2013-02-11 14:36:48 PST
I believe this broke the Windows build here: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/62268/steps/compile-webkit/logs/stdio
Benjamin Poulain
Comment 11 2013-02-11 14:40:23 PST
(In reply to comment #10) > I believe this broke the Windows build here: > http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/62268/steps/compile-webkit/logs/stdio I'll update the symbols. The bot was not working previously.
Benjamin Poulain
Comment 12 2013-02-11 14:52:48 PST
Windows symbols in http://trac.webkit.org/changeset/142519
Note You need to log in before you can comment on or make changes to this bug.