Bug 109348 - ScrollingTree node maps keep getting larger
Summary: ScrollingTree node maps keep getting larger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
: 108732 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-08 22:12 PST by Simon Fraser (smfr)
Modified: 2013-02-11 13:30 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.29 KB, patch)
2013-02-09 13:01 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-02-08 22:12:46 PST 
Both the ScrollingCoordinator's m_stateNodeMap and ScrollingTree's m_nodeMap get larger and larger as you navigate between pages.
Comment 1 Simon Fraser (smfr) 2013-02-09 13:01:22 PST 
Created attachment 187441 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-02-09 13:02:04 PST 
This patch depends on the patch in bug 109361, so will probably fail EWS.
Comment 3 Simon Fraser (smfr) 2013-02-09 13:03:28 PST 
The changelog should say that this isn't testable, because we only dump the state node tree (which is OK), not the hash map. The scrolling node tree does accumulate extra children, but we don't dump that.
Comment 4 Simon Fraser (smfr) 2013-02-11 13:30:16 PST 
http://trac.webkit.org/changeset/142505
Comment 5 Simon Fraser (smfr) 2013-02-11 13:30:52 PST 
*** Bug 108732 has been marked as a duplicate of this bug. ***