Bug 109333 - [TexMap] Separate classes per file in TextureMapperBackingStore.h
Summary: [TexMap] Separate classes per file in TextureMapperBackingStore.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Brandao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 16:40 PST by Rafael Brandao
Modified: 2013-02-09 10:17 PST (History)
9 users (show)

See Also:

Attachments
Patch (42.62 KB, patch)
2013-02-08 16:44 PST, Rafael Brandao 		no flags Details | Formatted Diff | Diff
Patch (44.68 KB, patch)
2013-02-08 20:31 PST, Rafael Brandao 		noam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Brandao 2013-02-08 16:40:19 PST 
[TexMap] Separate classes per file in TextureMapperBackingStore.h
Comment 1 Rafael Brandao 2013-02-08 16:44:23 PST 
Created attachment 187386 [details]
Patch
Comment 2 Rafael Brandao 2013-02-08 20:31:07 PST 
Created attachment 187403 [details]
Patch
Comment 3 Build Bot 2013-02-09 04:22:57 PST 
Comment on attachment 187403 [details]
Patch

Attachment 187403 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16465413

New failing tests:
compositing/checkerboard.html
accessibility/anchor-linked-anonymous-block-crash.html
compositing/absolute-inside-out-of-view-fixed.html
animations/3d/matrix-transform-type-animation.html
http/tests/cache/cancel-multiple-post-xhrs.html
animations/3d/state-at-end-event-transform.html
animations/animation-add-events-in-handler.html
animations/additive-transform-animations.html
animations/3d/replace-filling-transform.html
http/tests/cache/history-only-cached-subresource-loads.html
compositing/bounds-in-flipped-writing-mode.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
accessibility/accessibility-object-detached.html
accessibility/anonymous-render-block-in-continuation-causes-crash.html
animations/animation-controller-drt-api.html
compositing/absolute-position-changed-with-composited-parent-layer.html
compositing/absolute-position-changed-in-composited-layer.html
http/tests/cache/iframe-304-crash.html
animations/3d/transform-perspective.html
http/tests/cache/cancel-during-failure-crash.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
canvas/philip/tests/2d.clearRect.basic.html
animations/3d/transform-origin-vs-functions.html
accessibility/accessibility-node-memory-management.html
animations/animation-css-rule-types.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Comment 4 Noam Rosenthal 2013-02-09 08:29:00 PST 
Comment on attachment 187403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187403&action=review

I'm pretty sure the EWS redness has nothing to do with the patch. Please make sure before submitting.

> Source/WebCore/ChangeLog:10
> +        TextureMapperTile which was quite confusing. Now each one has its own header.

... and its own source file.

> Source/WebCore/ChangeLog:12
> +        No new tests needed, just refactor.

refactoring only.
Comment 5 Rafael Brandao 2013-02-09 10:17:09 PST 
Committed r142366: <http://trac.webkit.org/changeset/142366>