Bug 109322 - AX: move isIgnored caching to AXObject
Summary: AX: move isIgnored caching to AXObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 13:29 PST by Dominic Mazzoni
Modified: 2013-02-09 15:07 PST (History)
8 users (show)

See Also:

Attachments
Patch (38.77 KB, patch)
2013-02-08 13:39 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Patch (39.00 KB, patch)
2013-02-08 13:59 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Patch for landing (39.28 KB, patch)
2013-02-09 13:54 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2013-02-08 13:29:44 PST 
There's some benefit to caching accessibilityIsIgnored (using AXComputedObjectAttributeCache) for more than just AXRenderObject, so rather than duplicating a bunch of code, that code should probably be in AXObject.
Comment 1 Dominic Mazzoni 2013-02-08 13:39:17 PST 
Created attachment 187359 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 13:47:27 PST 
Comment on attachment 187359 [details]
Patch

Attachment 187359 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16435808
Comment 3 Dominic Mazzoni 2013-02-08 13:59:00 PST 
Created attachment 187361 [details]
Patch
Comment 4 chris fleizach 2013-02-08 17:49:31 PST 
Comment on attachment 187361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187361&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.h:97
> +    virtual bool computeAccessibilityIsIgnored() const;

looks like this should be private too
Comment 5 Dominic Mazzoni 2013-02-09 13:54:12 PST 
Created attachment 187445 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-02-09 15:07:39 PST 
Comment on attachment 187445 [details]
Patch for landing

Clearing flags on attachment: 187445

Committed r142382: <http://trac.webkit.org/changeset/142382>
Comment 7 WebKit Review Bot 2013-02-09 15:07:45 PST 
All reviewed patches have been landed.  Closing bug.