Bug 109303 – Add gyp option to switch ENABLE(SQL_DATABASE)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Paweł Hajdan, Jr.]

Add gyp option to switch ENABLE(SQL_DATABASE)

This will be useful to implement build with system sqlite, http://code.google.com/p/chromium/issues/detail?id=22208

[Paweł Hajdan, Jr.]

Created attachment 187319 [details]
patch

[Tony Chang]

Comment on attachment 187319 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187319&action=review

> Source/WebKit/chromium/ChangeLog:10
> +        Add gyp option to switch ENABLE(SQL_DATABASE)
> +        
> +        This will be useful to implement build with system sqlite,
> +        http://code.google.com/p/chromium/issues/detail?id=22208
> +        
> +        https://bugs.webkit.org/show_bug.cgi?id=109303
> +
> +        Reviewed by NOBODY (OOPS!).

This is a different order than other ChangeLog entries.  The bug link should go directly under the first line and the Reviewed by should go under that.

[Paweł Hajdan, Jr.]

Created attachment 188323 [details]
patch

[Tony Chang]

Created attachment 189334 [details]
patch

Fixed ChangeLog

[WebKit Review Bot]

Comment on attachment 189334 [details]
patch

Rejecting attachment 189334 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 189334, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
parse_author_text(self._author_text)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 164, in _parse_author_text
    return [cls._parse_author_name_and_email(author) for author in authors]
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 156, in _parse_author_name_and_email
    return {'name': match.group("name"), 'email': match.group("email")}
AttributeError: 'NoneType' object has no attribute 'group'

Full output: http://queues.webkit.org/results/16647418

[Tony Chang]

(In reply to comment #5)
> (From update of attachment 189334 [details])
> Rejecting attachment 189334 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'validate-changelog', '--non-interactive', 189334, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue
> 
> Last 500 characters of output:
> parse_author_text(self._author_text)
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 164, in _parse_author_text
>     return [cls._parse_author_name_and_email(author) for author in authors]
>   File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 156, in _parse_author_name_and_email
>     return {'name': match.group("name"), 'email': match.group("email")}
> AttributeError: 'NoneType' object has no attribute 'group'
> 
> Full output: http://queues.webkit.org/results/16647418

Hah, I was hitting this bug locally.  I'm working on a fix.  The ChangeLog parser is confused by the comma in Pawel's name.

[WebKit Review Bot]

Comment on attachment 189334 [details]
patch

Clearing flags on attachment: 189334

Committed r143511: <http://trac.webkit.org/changeset/143511>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.