Bug 109300 – [BlackBerry] Add form navigation control state tracking.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Mike Fenton]

SSIA.

[Mike Fenton]

Created attachment 187315 [details]
Patch

[WebKit Review Bot]

Attachment 187315 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage.h', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.h']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:934:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:936:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:938:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:939:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:940:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:941:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:942:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:943:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:944:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:945:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:946:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:947:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:948:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:949:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:950:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:951:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:952:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:953:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:955:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 20 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 187315 [details]
Patch

Attachment 187315 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16443652

New failing tests:
http/tests/cache/cached-main-resource.html

[Mike Fenton]

Created attachment 187341 [details]
Updated Patch

[Rob Buis]

Comment on attachment 187341 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187341&action=review

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:948
> +        for (int j = i + 1; j < formElementCount; j++) {

I think using j twice is confusing. Most compilers can probably deal with it but better not risk anything, and maybe choose more descriptive variable names.

[Mike Fenton]

Created attachment 187587 [details]
Updated patch with better variable naming.

[Rob Buis]

Comment on attachment 187587 [details]
Updated patch with better variable naming.

LGTM.

[WebKit Review Bot]

Comment on attachment 187587 [details]
Updated patch with better variable naming.

Clearing flags on attachment: 187587

Committed r142482: <http://trac.webkit.org/changeset/142482>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.