Bug 109297 – [chromium] add a make-non-copyable macro to TestRunner library and use it

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

since we depend on base/ anyway, we should use scoped_ptr instead of auto_ptr. And while we're at it, adding DISALLOW_COPY_AND_ASSIGN where appropriate might be a good idea, too

[Tony Chang]

We try to avoid direct dependencies on base/ because it makes it hard for people to make changes to base (since DRT is in a separate repository).  Normally we try to expose Chromium code through webkit/support.

It might be easier to put a copy of scoped_ptr.h in DumpRenderTree/chromium.

chromium's public WebKit API already depends on base, e.g. WebString includes <base/string16> (and GURL, WebURL includes gurl.h)

Of couse, we could copy the few files required, but I don't really see the point as there's no new dependency

[Tony Chang]

(In reply to comment #2)
> chromium's public WebKit API already depends on base, e.g. WebString includes <base/string16> (and GURL, WebURL includes gurl.h)

gurl.h is part of googleurl, not base.  base/string16.h is a layering violation, but perhaps we thought it was OK since it's not likely to change.  It's also important that the WebString string16 is the same as string16 in chromium.

> Of couse, we could copy the few files required, but I don't really see the point as there's no new dependency

I think we should still try to avoid adding dependencies to more files in base if they're easy to avoid.  scoped_ptr.h seems to undergo frequent changes. I don't want to slow that down with this dependency.  It would be easy to make a simplified scoped_ptr.h for use by DRT.

I guess we could also just stick with auto_ptr, and roll out own MAKE_NON_COPYABLE macro

[Tony Chang]

(In reply to comment #4)
> I guess we could also just stick with auto_ptr, and roll out own MAKE_NON_COPYABLE macro

That sounds fine to me.