Bug 109292 - RTCPeerConnection.getStats() fails when remote stats are instantiated.
Summary: RTCPeerConnection.getStats() fails when remote stats are instantiated.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Harald Alvestrand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 05:51 PST by Harald Alvestrand
Modified: 2013-02-08 09:07 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2013-02-08 06:36 PST, Harald Alvestrand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Alvestrand 2013-02-08 05:51:28 PST
Assert failure observed. Stack trace:

webkit!WebCore::RTCStatsReport::addElement+0xe4
webkit!WebCore::RTCStatsResponse::addElement+0x6b
webkit!WebKit::WebRTCStatsResponse::addElement+0x44
content!content::LocalRTCStatsResponse::addElement+0x2f
content!content::StatsResponse::AddElement+0x72
content!content::StatsResponse::OnComplete+0x149
content!webrtc::PeerConnection::OnMessage+0x21c
content!jingle_glue::JingleThreadWrapper::RunTask+0x283

Code:

void RTCStatsReport::addElement(bool isLocal, double timestamp)
{
    if (isLocal) {
        ASSERT(!m_local);
        m_local = RTCStatsElement::create(timestamp);
    }
    ASSERT(!m_remote);  <<============================================
    m_remote = RTCStatsElement::create(timestamp);
}

Missing RETURN inside if block.
Comment 1 Harald Alvestrand 2013-02-08 06:36:32 PST
Created attachment 187308 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 09:07:04 PST
Comment on attachment 187308 [details]
Patch

Clearing flags on attachment: 187308

Committed r142289: <http://trac.webkit.org/changeset/142289>
Comment 3 WebKit Review Bot 2013-02-08 09:07:07 PST
All reviewed patches have been landed.  Closing bug.