Bug 109289 - Web Inspector: introduce WebInspector.TextUtils
Summary: Web Inspector: introduce WebInspector.TextUtils
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 05:26 PST by Andrey Lushnikov
Modified: 2013-02-11 07:42 PST (History)
10 users (show)

See Also:


Attachments
Patch (11.05 KB, patch)
2013-02-08 05:36 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff
Patch (11.05 KB, patch)
2013-02-08 06:13 PST, Andrey Lushnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-08 05:26:42 PST
Create a WebInspector.TextUtils namespace which will hold such methods as "isWord" and "isStopChar" which are going to be heavily used inside of DefaultTextEditor.
Comment 1 Andrey Lushnikov 2013-02-08 05:36:29 PST
Created attachment 187300 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-08 05:42:45 PST
Comment on attachment 187300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187300&action=review

> Source/WebCore/inspector/front-end/TextUtils.js:69
> +        for(var i = 0; i < word.length; ++i) {

Missing whitespace after "for"
Comment 3 Early Warning System Bot 2013-02-08 05:45:42 PST
Comment on attachment 187300 [details]
Patch

Attachment 187300 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16445688
Comment 4 Alexander Pavlov (apavlov) 2013-02-08 05:47:49 PST
Comment on attachment 187300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187300&action=review

> Source/WebCore/inspector/front-end/WebKit.qrc:207
> +    <file>TextUtils.js</file>'

Oops, an "'" after </file>
Comment 5 Early Warning System Bot 2013-02-08 05:48:47 PST
Comment on attachment 187300 [details]
Patch

Attachment 187300 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16415739
Comment 6 Andrey Lushnikov 2013-02-08 06:13:50 PST
Created attachment 187303 [details]
Patch
Comment 7 Pavel Feldman 2013-02-09 01:42:10 PST
Comment on attachment 187303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187303&action=review

> Source/WebCore/inspector/front-end/TextUtils.js:31
> +WebInspector.TextUtils = {

Is it going to be used outside of the editor? These methods look very editor-specific. Is there a reason we declare it all outside DefaultTextEditor and/or TextEditorModel.
Comment 8 Andrey Lushnikov 2013-02-10 23:17:16 PST
Comment on attachment 187303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187303&action=review

>> Source/WebCore/inspector/front-end/TextUtils.js:31
>> +WebInspector.TextUtils = {
> 
> Is it going to be used outside of the editor? These methods look very editor-specific. Is there a reason we declare it all outside DefaultTextEditor and/or TextEditorModel.

These methods don't have any notion of DefaultTextEditor/TextEditorModel, and due to their generic nature I decided to separate them into an independent namespace. Although they are not used anywhere except DTE at the moment, one day they might be found useful in other text-editing parts of front-end, e.g. TextPrompt.
Comment 9 WebKit Review Bot 2013-02-11 07:41:56 PST
Comment on attachment 187303 [details]
Patch

Clearing flags on attachment: 187303

Committed r142471: <http://trac.webkit.org/changeset/142471>
Comment 10 WebKit Review Bot 2013-02-11 07:42:00 PST
All reviewed patches have been landed.  Closing bug.