Create a WebInspector.TextUtils namespace which will hold such methods as "isWord" and "isStopChar" which are going to be heavily used inside of DefaultTextEditor.
Created attachment 187300 [details] Patch
Comment on attachment 187300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187300&action=review > Source/WebCore/inspector/front-end/TextUtils.js:69 > + for(var i = 0; i < word.length; ++i) { Missing whitespace after "for"
Comment on attachment 187300 [details] Patch Attachment 187300 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16445688
Comment on attachment 187300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187300&action=review > Source/WebCore/inspector/front-end/WebKit.qrc:207 > + <file>TextUtils.js</file>' Oops, an "'" after </file>
Comment on attachment 187300 [details] Patch Attachment 187300 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16415739
Created attachment 187303 [details] Patch
Comment on attachment 187303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187303&action=review > Source/WebCore/inspector/front-end/TextUtils.js:31 > +WebInspector.TextUtils = { Is it going to be used outside of the editor? These methods look very editor-specific. Is there a reason we declare it all outside DefaultTextEditor and/or TextEditorModel.
Comment on attachment 187303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187303&action=review >> Source/WebCore/inspector/front-end/TextUtils.js:31 >> +WebInspector.TextUtils = { > > Is it going to be used outside of the editor? These methods look very editor-specific. Is there a reason we declare it all outside DefaultTextEditor and/or TextEditorModel. These methods don't have any notion of DefaultTextEditor/TextEditorModel, and due to their generic nature I decided to separate them into an independent namespace. Although they are not used anywhere except DTE at the moment, one day they might be found useful in other text-editing parts of front-end, e.g. TextPrompt.
Comment on attachment 187303 [details] Patch Clearing flags on attachment: 187303 Committed r142471: <http://trac.webkit.org/changeset/142471>
All reviewed patches have been landed. Closing bug.