RESOLVED WONTFIX 109286
Web Inspector: Avoid using offsetWidth/offsetHeight in SplitView 
https://bugs.webkit.org/show_bug.cgi?id=109286
Summary Web Inspector: Avoid using offsetWidth/offsetHeight in SplitView
Vladislav Kaznacheev
Reported 2013-02-08 04:40:39 PST
Currently the SplitView code relies on offsetWidth/offsetHeight to get the dimension which is constant and set in CSS.
Attachments
Patch (3.90 KB, patch)
2013-02-08 04:42 PST, Vladislav Kaznacheev 		pfeldman: review-
pfeldman: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vladislav Kaznacheev
Comment 1 2013-02-08 04:42:49 PST
Created attachment 187290 [details] Patch
Pavel Feldman
Comment 2 2013-02-08 04:57:29 PST
Comment on attachment 187290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187290&action=review > Source/WebCore/inspector/front-end/SplitView.js:-295 > - var resizerWidth = this._resizerElement.offsetWidth; Why making resize 0-width? You should simply cache the value or calculate it before you damage layout in _removeAllLayoutProperties above.
Pavel Feldman
Comment 3 2013-02-08 05:02:17 PST
Comment on attachment 187290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187290&action=review >> Source/WebCore/inspector/front-end/SplitView.js:-295 >> - var resizerWidth = this._resizerElement.offsetWidth; > > Why making resize 0-width? You should simply cache the value or calculate it before you damage layout in _removeAllLayoutProperties above. Ok, taking it back - Vsevolod explained to me that it did not change. But why duping -2.5 for 5?
Vsevolod Vlasov
Comment 4 2013-02-08 05:37:14 PST
As discussed offline with Pavel splitter should hover equally on both side of the split view by default. Let's cache offsetWidth once and keep division by 2 for now.
Note You need to log in before you can comment on or make changes to this bug.