Bug 109285 - [Curl] setCookiesFromDOM function does not save cookies to disk.
Summary: [Curl] setCookiesFromDOM function does not save cookies to disk.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-08 04:23 PST by peavo
Modified: 2013-02-11 23:49 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2013-02-08 04:50 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (4.20 KB, patch)
2013-02-11 04:31 PST, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-02-08 04:23:08 PST
The function setCookiesFromDOM in Source/WebCore/platform/network/curl/CookieJarCurl.cpp does not save cookies to disk, only in a hash table in memory.
Comment 1 peavo 2013-02-08 04:50:01 PST
Created attachment 187292 [details]
Patch
Comment 2 Brent Fulgham 2013-02-08 09:17:00 PST
Comment on attachment 187292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187292&action=review

Very nice update.  Please switch to an "early return" style for that one method, since no other actions are taken in the case where the CURL handle is null.

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:37
> +    if (curl) {

Please make this an early return, since we do nothing if the curl interface is not present.
Comment 3 peavo 2013-02-11 04:31:27 PST
Created attachment 187545 [details]
Patch
Comment 4 peavo 2013-02-11 04:34:19 PST
Updated patch according to the review comments, and set Curl option to share the Curl cookie database, when adding the cookie.
Comment 5 Brent Fulgham 2013-02-11 20:29:52 PST
Comment on attachment 187545 [details]
Patch

Looks great!  Thanks for getting this working.
Comment 6 WebKit Review Bot 2013-02-11 20:35:59 PST
Comment on attachment 187545 [details]
Patch

Clearing flags on attachment: 187545

Committed r142574: <http://trac.webkit.org/changeset/142574>
Comment 7 WebKit Review Bot 2013-02-11 20:36:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 peavo 2013-02-11 23:49:16 PST
(In reply to comment #5)
> (From update of attachment 187545 [details])
> Looks great!  Thanks for getting this working.

Thanks alot for the review ;)