Bug 109285 – [Curl] setCookiesFromDOM function does not save cookies to disk.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

The function setCookiesFromDOM in Source/WebCore/platform/network/curl/CookieJarCurl.cpp does not save cookies to disk, only in a hash table in memory.

Created attachment 187292 [details]
Patch

[Brent Fulgham]

Comment on attachment 187292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187292&action=review

Very nice update.  Please switch to an "early return" style for that one method, since no other actions are taken in the case where the CURL handle is null.

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:37
> +    if (curl) {

Please make this an early return, since we do nothing if the curl interface is not present.

Created attachment 187545 [details]
Patch

Updated patch according to the review comments, and set Curl option to share the Curl cookie database, when adding the cookie.

[Brent Fulgham]

Comment on attachment 187545 [details]
Patch

Looks great!  Thanks for getting this working.

[WebKit Review Bot]

Comment on attachment 187545 [details]
Patch

Clearing flags on attachment: 187545

Committed r142574: <http://trac.webkit.org/changeset/142574>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #5)
> (From update of attachment 187545 [details])
> Looks great!  Thanks for getting this working.

Thanks alot for the review ;)