Restore pre-r118852 behavior for EllipsisBox::nodeAtPoint()
Created attachment 187273 [details] Patch
Andy, thanks for working on this. Does fast/css/text-overflow-ellipsis-hit-test.html still pass with this change? The original change closed one bug and opened another due to two behaviours sharing a code path. ie. -webkit-line-clamp vs text-overflow:ellipsis. Without distinguishing between these, we are exchanging one bug for another.
(In reply to comment #2) > Andy, thanks for working on this. Does fast/css/text-overflow-ellipsis-hit-test.html still pass with this change? The original change closed one bug and opened another due to two behaviours sharing a code path. ie. -webkit-line-clamp vs text-overflow:ellipsis. Without distinguishing between these, we are exchanging one bug for another. I'll check the status of that test, but I expect this will break it. The point of this change is simply to revert to the behavior prior to the original change. I think we're willing to re-introduce a spec compliance bug in order to fix an important WebKit client. We lived with the original behavior for over 8 years, so we can live with it a little longer until we find a regression-free fix.
Comment on attachment 187273 [details] Patch Attachment 187273 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16434641 New failing tests: fast/css/text-overflow-ellipsis-hit-test.html
Another way of putting this is that this is a roll-out that we should do until we find a better fix for the original bug. I think a roll-out makes sense in this case. If possible, we should add a regression test demonstrating the problem that necessitates the roll-out.
Comment on attachment 187273 [details] Patch Attachment 187273 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16430619 New failing tests: fast/css/text-overflow-ellipsis-hit-test.html
Comment on attachment 187273 [details] Patch Attachment 187273 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16434685 New failing tests: fast/css/text-overflow-ellipsis-hit-test.html
Comment on attachment 187273 [details] Patch Code looks good, but you should add a test.
You could check in the failing expectated.txt for fast/css/text-overflow-ellipsis-hit-test.html since that is the new expected behavior.
Since we're rolling out a patch, the test added by the patch should also be rolled out: LayoutTests/fast/css/text-overflow-ellipsis-hit-test.html
Created attachment 187390 [details] Patch
Committed r142335: <http://trac.webkit.org/changeset/142335>