WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
109253
[BlackBerry] webpage needs null check in BackingStore::setCurrentBackingStoreOwner
https://bugs.webkit.org/show_bug.cgi?id=109253
Summary
[BlackBerry] webpage needs null check in BackingStore::setCurrentBackingStore...
Charles Wei
Reported
2013-02-07 21:19:31 PST
In void BackingStorePrivate::setCurrentBackingStoreOwner(WebPage* webPage) { // Let the previously active backingstore release its tile buffers so // the new one (e.g. another tab) can use the buffers to render contents. if (BackingStorePrivate::s_currentBackingStoreOwner && BackingStorePrivate::s_currentBackingStoreOwner != webPage) BackingStorePrivate::s_currentBackingStoreOwner->d->m_backingStore->d->resetTiles(); BackingStorePrivate::s_currentBackingStoreOwner = webPage; webPage->backingStore()->d->updateSuspendScreenUpdateState(); // depends on isActive() } webPage could be null when a tab is been deleted, so we need to check for null before using webPage.
Attachments
Patch
(1.56 KB, patch)
2013-02-07 21:24 PST
,
Charles Wei
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Charles Wei
Comment 1
2013-02-07 21:24:37 PST
Created
attachment 187232
[details]
Patch
Charles Wei
Comment 2
2013-02-07 21:28:10 PST
Comment on
attachment 187232
[details]
Patch Already reviewed and approved by George. Commit it.
WebKit Review Bot
Comment 3
2013-02-07 21:49:23 PST
Comment on
attachment 187232
[details]
Patch Clearing flags on attachment: 187232 Committed
r142227
: <
http://trac.webkit.org/changeset/142227
>
WebKit Review Bot
Comment 4
2013-02-07 21:49:26 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug