Bug 109253 - [BlackBerry] webpage needs null check in BackingStore::setCurrentBackingStoreOwner
Summary: [BlackBerry] webpage needs null check in BackingStore::setCurrentBackingStore...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 21:19 PST by Charles Wei
Modified: 2013-02-08 04:16 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2013-02-07 21:24 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2013-02-07 21:19:31 PST
In 
void BackingStorePrivate::setCurrentBackingStoreOwner(WebPage* webPage)
{
    // Let the previously active backingstore release its tile buffers so
    // the new one (e.g. another tab) can use the buffers to render contents.
    if (BackingStorePrivate::s_currentBackingStoreOwner && BackingStorePrivate::s_currentBackingStoreOwner != webPage)
        BackingStorePrivate::s_currentBackingStoreOwner->d->m_backingStore->d->resetTiles();

    BackingStorePrivate::s_currentBackingStoreOwner = webPage;
    webPage->backingStore()->d->updateSuspendScreenUpdateState(); // depends on isActive()
}

webPage could be null when a tab is been deleted, so we need to check for null before using webPage.
Comment 1 Charles Wei 2013-02-07 21:24:37 PST
Created attachment 187232 [details]
Patch
Comment 2 Charles Wei 2013-02-07 21:28:10 PST
Comment on attachment 187232 [details]
Patch

Already reviewed and approved by George. Commit it.
Comment 3 WebKit Review Bot 2013-02-07 21:49:23 PST
Comment on attachment 187232 [details]
Patch

Clearing flags on attachment: 187232

Committed r142227: <http://trac.webkit.org/changeset/142227>
Comment 4 WebKit Review Bot 2013-02-07 21:49:26 PST
All reviewed patches have been landed.  Closing bug.