Bug 109240 - Fix TextDocumentParser to play nice with threading
Summary: Fix TextDocumentParser to play nice with threading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
: 107330 (view as bug list)
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-02-07 16:20 PST by Eric Seidel (no email)
Modified: 2013-02-09 09:54 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2013-02-07 16:23 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (3.46 KB, patch)
2013-02-07 17:27 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (7.45 KB, patch)
2013-02-08 11:00 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (5.97 KB, patch)
2013-02-08 11:35 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-02-07 16:20:34 PST 
Fix TextDocumentParser to play nice with threading
Comment 1 Eric Seidel (no email) 2013-02-07 16:23:45 PST 
Created attachment 187195 [details]
Patch
Comment 2 Adam Barth 2013-02-07 16:28:29 PST 
I'm not 100% sure that the line number change isn't detectable, but this approach is much cleaner.
Comment 3 Eric Seidel (no email) 2013-02-07 16:30:40 PST 
This only affects the column number, and only on the first line.

But I don't think the line numbers during TextDocument parsing are ever used by the rest of WebCore, even in the inspector.
Comment 4 Build Bot 2013-02-07 16:58:25 PST 
Comment on attachment 187195 [details]
Patch

Attachment 187195 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16434391

New failing tests:
fast/tokenizer/text-plain.html
http/tests/security/xss-DENIED-mime-type-execute-as-html.html
http/tests/misc/acid3.html
Comment 5 Eric Seidel (no email) 2013-02-07 17:27:45 PST 
Created attachment 187207 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-02-07 18:33:38 PST 
Comment on attachment 187207 [details]
Patch for landing

Attachment 187207 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16438419

New failing tests:
fast/text/plain-text-line-breaks.html
fast/forms/targeted-frame-submission.html
fast/loader/text-document-wrapping.html
Comment 7 Build Bot 2013-02-07 18:58:15 PST 
Comment on attachment 187207 [details]
Patch for landing

Attachment 187207 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16448010

New failing tests:
fast/text/plain-text-line-breaks.html
fast/forms/targeted-frame-submission.html
http/tests/misc/acid3.html
fast/loader/text-document-wrapping.html
Comment 8 Adam Barth 2013-02-08 10:47:20 PST 
*** Bug 107330 has been marked as a duplicate of this bug. ***
Comment 9 Eric Seidel (no email) 2013-02-08 11:00:49 PST 
Created attachment 187338 [details]
Patch for landing
Comment 10 Adam Barth 2013-02-08 11:31:16 PST 
Comment on attachment 187338 [details]
Patch for landing

This conflicts with the WeakPtr patch.  I'll merge manually.
Comment 11 Adam Barth 2013-02-08 11:35:50 PST 
Created attachment 187342 [details]
Patch for landing
Comment 12 WebKit Review Bot 2013-02-09 09:53:56 PST 
Comment on attachment 187342 [details]
Patch for landing

Clearing flags on attachment: 187342

Committed r142363: <http://trac.webkit.org/changeset/142363>
Comment 13 WebKit Review Bot 2013-02-09 09:54:00 PST 
All reviewed patches have been landed.  Closing bug.