Bug 109239 – Move workerThreadCount from TestRunner to WebCore Internals

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

Move workerThreadCount from TestRunner to WebCore Internals

[Benjamin Poulain]

Created attachment 187193 [details]
Patch

[Benjamin Poulain]

Damn, why does it always have to be GTK :( :(

I'll add the symbol before landing.

[kov's GTK+ EWS bot]

Comment on attachment 187193 [details]
Patch

Attachment 187193 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16427430

[Darin Adler]

Comment on attachment 187193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187193&action=review

Please check into the GTK build failure before landing.

> Source/WebCore/testing/Internals.h:209
> +    unsigned long workerThreadCount() const;

IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here.

[Build Bot]

Comment on attachment 187193 [details]
Patch

Attachment 187193 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16427530

[Benjamin Poulain]

> > Source/WebCore/testing/Internals.h:209
> > +    unsigned long workerThreadCount() const;
> 
> IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here.

Good catch! An unfortunate copy-paste.

[Benjamin Poulain]

Created attachment 187268 [details]
Patch

[Early Warning System Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16445616

[WebKit Review Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16428580

[WebKit Review Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16453015

[Early Warning System Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16435551

[EFL EWS Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16408680

[Build Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16415673

[Peter Beverloo (cr-android ews)]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16443527

[Build Bot]

Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16432580

[Benjamin Poulain]

Created attachment 187348 [details]
Patch

[Benjamin Poulain]

Comment on attachment 187348 [details]
Patch

Clearing flags on attachment: 187348

Committed r142348: <http://trac.webkit.org/changeset/142348>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.