Bug 109239 - Move workerThreadCount from TestRunner to WebCore Internals
Summary: Move workerThreadCount from TestRunner to WebCore Internals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 16:17 PST by Benjamin Poulain
Modified: 2013-02-08 21:19 PST (History)
17 users (show)

See Also:

Attachments
Patch (45.82 KB, patch)
2013-02-07 16:20 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (48.32 KB, patch)
2013-02-08 01:48 PST, Benjamin Poulain 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (48.31 KB, patch)
2013-02-08 12:28 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-02-07 16:17:20 PST 
Move workerThreadCount from TestRunner to WebCore Internals
Comment 1 Benjamin Poulain 2013-02-07 16:20:17 PST 
Created attachment 187193 [details]
Patch
Comment 2 Benjamin Poulain 2013-02-07 17:37:22 PST 
Damn, why does it always have to be GTK :( :(

I'll add the symbol before landing.
Comment 3 kov's GTK+ EWS bot 2013-02-07 18:54:33 PST 
Comment on attachment 187193 [details]
Patch

Attachment 187193 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16427430
Comment 4 Darin Adler 2013-02-07 20:16:46 PST 
Comment on attachment 187193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187193&action=review

Please check into the GTK build failure before landing.

> Source/WebCore/testing/Internals.h:209
> +    unsigned long workerThreadCount() const;

IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here.
Comment 5 Build Bot 2013-02-08 01:01:42 PST 
Comment on attachment 187193 [details]
Patch

Attachment 187193 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16427530
Comment 6 Benjamin Poulain 2013-02-08 01:45:49 PST 
> > Source/WebCore/testing/Internals.h:209
> > +    unsigned long workerThreadCount() const;
> 
> IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here.

Good catch! An unfortunate copy-paste.
Comment 7 Benjamin Poulain 2013-02-08 01:48:03 PST 
Created attachment 187268 [details]
Patch
Comment 8 Early Warning System Bot 2013-02-08 01:56:30 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16445616
Comment 9 WebKit Review Bot 2013-02-08 01:56:54 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16428580
Comment 10 WebKit Review Bot 2013-02-08 01:59:05 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16453015
Comment 11 Early Warning System Bot 2013-02-08 02:00:16 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16435551
Comment 12 EFL EWS Bot 2013-02-08 02:03:35 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16408680
Comment 13 Build Bot 2013-02-08 02:08:04 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16415673
Comment 14 Peter Beverloo (cr-android ews) 2013-02-08 02:12:50 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16443527
Comment 15 Build Bot 2013-02-08 02:14:43 PST 
Comment on attachment 187268 [details]
Patch

Attachment 187268 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16432580
Comment 16 Benjamin Poulain 2013-02-08 12:28:39 PST 
Created attachment 187348 [details]
Patch
Comment 17 Benjamin Poulain 2013-02-08 21:19:22 PST 
Comment on attachment 187348 [details]
Patch

Clearing flags on attachment: 187348

Committed r142348: <http://trac.webkit.org/changeset/142348>
Comment 18 Benjamin Poulain 2013-02-08 21:19:29 PST 
All reviewed patches have been landed.  Closing bug.